Remove unreachable code (g_rpcSignals.PostCommand)

practicalswift · practicalswift · commit 54fae05dad26 · 2017-03-09T09:47:04.000+01:00
diff --git a/src/rpc/server.cpp b/src/rpc/server.cpp
@@ -45,7 +45,6 @@ static struct CRPCSignals
     boost::signals2::signal<void ()> Started;
     boost::signals2::signal<void ()> Stopped;
     boost::signals2::signal<void (const CRPCCommand&)> PreCommand;
-    boost::signals2::signal<void (const CRPCCommand&)> PostCommand;
 } g_rpcSignals;
 
 void RPCServer::OnStarted(boost::function<void ()> slot)
@@ -63,11 +62,6 @@ void RPCServer::OnPreCommand(boost::function<void (const CRPCCommand&)> slot)
     g_rpcSignals.PreCommand.connect(boost::bind(slot, _1));
 }
 
-void RPCServer::OnPostCommand(boost::function<void (const CRPCCommand&)> slot)
-{
-    g_rpcSignals.PostCommand.connect(boost::bind(slot, _1));
-}
-
 void RPCTypeCheck(const UniValue& params,
                   const list<UniValue::VType>& typesExpected,
                   bool fAllowNull)
@@ -492,8 +486,6 @@ UniValue CRPCTable::execute(const JSONRPCRequest &request) const
     {
         throw JSONRPCError(RPC_MISC_ERROR, e.what());
     }
-
-    g_rpcSignals.PostCommand(*pcmd);
 }
 
 std::vector<std::string> CRPCTable::listCommands() const

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,6 @@ static struct CRPCSignals`
`45`	`45`	`boost::signals2::signal<void ()> Started;`
`46`	`46`	`boost::signals2::signal<void ()> Stopped;`
`47`	`47`	`boost::signals2::signal<void (const CRPCCommand&)> PreCommand;`
`48`		`- boost::signals2::signal<void (const CRPCCommand&)> PostCommand;`
`49`	`48`	`} g_rpcSignals;`
`50`	`49`
`51`	`50`	`void RPCServer::OnStarted(boost::function<void ()> slot)`
`@@ -63,11 +62,6 @@ void RPCServer::OnPreCommand(boost::function<void (const CRPCCommand&)> slot)`
`63`	`62`	`g_rpcSignals.PreCommand.connect(boost::bind(slot, _1));`
`64`	`63`	`}`
`65`	`64`
`66`		`-void RPCServer::OnPostCommand(boost::function<void (const CRPCCommand&)> slot)`
`67`		`-{`
`68`		`- g_rpcSignals.PostCommand.connect(boost::bind(slot, _1));`
`69`		`-}`
`70`		`-`
`71`	`65`	`void RPCTypeCheck(const UniValue& params,`
`72`	`66`	`const list<UniValue::VType>& typesExpected,`
`73`	`67`	`bool fAllowNull)`
`@@ -492,8 +486,6 @@ UniValue CRPCTable::execute(const JSONRPCRequest &request) const`
`492`	`486`	`{`
`493`	`487`	`throw JSONRPCError(RPC_MISC_ERROR, e.what());`
`494`	`488`	`}`
`495`		`-`
`496`		`- g_rpcSignals.PostCommand(*pcmd);`
`497`	`489`	`}`
`498`	`490`
`499`	`491`	`std::vector<std::string> CRPCTable::listCommands() const`