@@ -1423,36 +1423,32 @@ static void ThreadMapPort()
14231423 if (fDiscover ) {
14241424 char externalIPAddress[40 ];
14251425 r = UPNP_GetExternalIPAddress (urls.controlURL , data.first .servicetype , externalIPAddress);
1426- if (r != UPNPCOMMAND_SUCCESS)
1426+ if (r != UPNPCOMMAND_SUCCESS) {
14271427 LogPrintf (" UPnP: GetExternalIPAddress() returned %d\n " , r);
1428- else
1429- {
1430- if (externalIPAddress[0 ])
1431- {
1428+ } else {
1429+ if (externalIPAddress[0 ]) {
14321430 CNetAddr resolved;
1433- if (LookupHost (externalIPAddress, resolved, false )) {
1431+ if (LookupHost (externalIPAddress, resolved, false )) {
14341432 LogPrintf (" UPnP: ExternalIPAddress = %s\n " , resolved.ToString ().c_str ());
14351433 AddLocal (resolved, LOCAL_UPNP);
14361434 }
1437- }
1438- else
1435+ } else {
14391436 LogPrintf (" UPnP: GetExternalIPAddress failed.\n " );
1437+ }
14401438 }
14411439 }
14421440
14431441 std::string strDesc = PACKAGE_NAME " " + FormatFullVersion ();
14441442
14451443 do {
1446- r = UPNP_AddPortMapping (urls.controlURL , data.first .servicetype ,
1447- port.c_str (), port.c_str (), lanaddr, strDesc.c_str (), " TCP" , 0 , " 0" );
1444+ r = UPNP_AddPortMapping (urls.controlURL , data.first .servicetype , port.c_str (), port.c_str (), lanaddr, strDesc.c_str (), " TCP" , 0 , " 0" );
14481445
1449- if (r!=UPNPCOMMAND_SUCCESS)
1450- LogPrintf (" AddPortMapping(%s, %s, %s) failed with code %d (%s)\n " ,
1451- port, port, lanaddr, r, strupnperror (r));
1452- else
1446+ if (r != UPNPCOMMAND_SUCCESS) {
1447+ LogPrintf (" AddPortMapping(%s, %s, %s) failed with code %d (%s)\n " , port, port, lanaddr, r, strupnperror (r));
1448+ } else {
14531449 LogPrintf (" UPnP Port Mapping successful.\n " );
1454- }
1455- while (g_upnp_interrupt.sleep_for (std::chrono::minutes (20 )));
1450+ }
1451+ } while (g_upnp_interrupt.sleep_for (std::chrono::minutes (20 )));
14561452
14571453 r = UPNP_DeletePortMapping (urls.controlURL , data.first .servicetype , port.c_str (), " TCP" , 0 );
14581454 LogPrintf (" UPNP_DeletePortMapping() returned: %d\n " , r);
0 commit comments