test: Add AsyncEventLoop and executor tests#6
Merged
Conversation
This was referenced Dec 2, 2025
scottmarchant
changed the title
scottmarchant
force-pushed
the
chore/addTestUtils
branch
from
December 2, 2025 18:24
d635942 to
040dfae
Compare
scottmarchant
force-pushed
the
test/testAELAndAELExecutor
branch
from
December 2, 2025 18:25
e43ca9c to
d6aec0d
Compare
scottmarchant
commented
Dec 2, 2025
scottmarchant
requested review from
CrownedPhoenix,
karloscarweber and
krodak
December 2, 2025 20:18
scottmarchant
marked this pull request as ready for review
December 2, 2025 20:20
68 tasks
krodak
approved these changes
Dec 3, 2025
scottmarchant
force-pushed
the
chore/addTestUtils
branch
from
December 3, 2025 20:50
040dfae to
33c9904
Compare
scottmarchant
force-pushed
the
test/testAELAndAELExecutor
branch
from
December 3, 2025 20:52
d6aec0d to
bc64955
Compare
karloscarweber
approved these changes
Dec 3, 2025
scottmarchant
force-pushed
the
chore/addTestUtils
branch
from
December 5, 2025 00:31
33c9904 to
cd502ef
Compare
…st majority of these tests were ported from NIOPosix tests for SelectableEventLoop, which AsyncEventLoop replaces.
scottmarchant
force-pushed
the
test/testAELAndAELExecutor
branch
from
December 5, 2025 01:00
bc64955 to
73eb0de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ported tests from NIOPosix that test the implementations of
AsyncEventLoopandMultiThreadedEventLoopGroupin NIOAsyncRuntime. TheAsyncEventLoopExecutoris also tested intrinsically.ℹ️ Because these tests are ported, we prefer to keep them in their current format and implementation to make comparison with tests in NIOPosix easier down the road. At some point, if NIOAsyncRuntime is ever merged into swift-nio, the tests may be consolidated.
Details
PR Dependencies
#5
Overview of all changes
All planned changes can be viewed together in #2