Skip to content

Document ServiceControl / ServicePulse support for authentication and SSL/TLS#7947

Merged
jasontaylordev merged 27 commits intomasterfrom
genxp-3600-add-authentication
Feb 9, 2026
Merged

Document ServiceControl / ServicePulse support for authentication and SSL/TLS#7947
jasontaylordev merged 27 commits intomasterfrom
genxp-3600-add-authentication

Conversation

@jasontaylordev
Copy link
Contributor

@jasontaylordev jasontaylordev commented Dec 11, 2025

@jasontaylordev jasontaylordev force-pushed the genxp-3600-add-authentication branch from 175b8ea to 604ff09 Compare January 8, 2026 06:42
- Renamed "HTTPS" to "TLS" in menu.yaml and added "CORS" section.
- Enhanced configuration documentation for HTTP to HTTPS redirection in audit and monitoring instances.
- Added new settings for HTTPS port in ServiceControl configuration.
- Introduced CORS configuration documentation for ServiceControl instances.
- Updated authentication documentation to clarify the use of Microsoft Entra ID and other OIDC providers.
- Added TLS configuration documentation detailing direct HTTPS and reverse proxy setups.
- Improved overall security overview and deployment scenarios in the ServiceControl documentation.
@johnsimons
Copy link
Member

I noticed we refer to Kestrel, I understand a dotnet dev probably knows what that is, but i am wondering if a ops person that is installing and configuring SC and SP would know what that means?

@johnsimons
Copy link
Member

This page has not been updated at all, I was expecting to see some changes there

@jasontaylordev jasontaylordev merged commit eb6aa95 into master Feb 9, 2026
4 checks passed
@jasontaylordev jasontaylordev deleted the genxp-3600-add-authentication branch February 9, 2026 01:41
- servicecontrol/security/hosting-guide
---

Cross-Origin Resource Sharing (CORS) controls which web applications can make requests to ServiceControl. This is important when ServicePulse is hosted on a different domain than ServiceControl.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it also important if ServicePulse is hosted on the same domain but a different port? Essentially it's required unless SP is hosted out of SC, which hasn't been released yet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port does matter, so we should probably add this. Its also worth noting that by default, CORS allows all origins. So if the customer doesn't change this, the request from the same host but different port will succeed.


**Symptom**: ServicePulse displays connection errors or fails to load data, and browser developer tools show CORS errors like "Access-Control-Allow-Origin" or "blocked by CORS policy".

**Cause**: The ServicePulse origin is not in the allowed origins list, or the origin URL doesn't match exactly (including protocol and port).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no reference made to port anywhere above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add info about the port and protocol where you flagged this higher up in the doc


_Added in version 6.11.0_

Trusts forwarded headers from any source. Set to `false` when using `KnownProxies` or `KnownNetworks`.
Copy link
Contributor

@PhilBastian PhilBastian Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to false when using KnownProxies or KnownNetworks.

this is ambiguous in its meaning. Should it be:

  • Set this to false when using KnownProxies or KnownNetworks; or
  • This is set to false when using KnownProxies or KnownNetworks?

the warning below suggests the former

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the warning is just making it clear that its recommended that this setting should be set to false, however which way that is done. But the user can either set it explicitly, or if the users sets KnownProxies or KnownNetworks, then this setting is automatically set to false. So it should be latter.

PhilBastian added a commit that referenced this pull request Feb 12, 2026
PhilBastian added a commit that referenced this pull request Feb 13, 2026
* spelling and grammar review of #7947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants