Fix issue with colliding atom types in structure addition #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates to OpenMM 7.6 support (previously only ported to v3.4 branch) and some other code cleanups.
This was referenced Oct 1, 2021
peastman
reviewed
Oct 2, 2021
* Drop support for OpenMM <7.6 (convert all imports to "openmm" namespace) * Update some *really* old chemistry imports (pre-parmed namespace) * Update documentation
Contributor
Author
|
This now also closes #1173 |
Contributor
Author
|
I’m going to merge this as the test case verifies the bug is fixed. |
Contributor
|
One of my folks just ran into this "bug" (issue/limitation) again; any chance we can get a release? It looks like this is only in master and not in a release yet. |
Contributor
Author
|
Yea I can do a 4.0 release soon. I merged a bunch of work into master recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates to OpenMM 7.6 support (previously only ported to v3.4
branch) and some other code cleanups.
Fixes #1197