Skip to content

Add icons for TheXTech and SMBX - #4033

Merged
varlesh merged 3 commits into
PapirusDevelopmentTeam:masterfrom
ninstar:thextech-smbx
Apr 29, 2025
Merged

Add icons for TheXTech and SMBX#4033
varlesh merged 3 commits into
PapirusDevelopmentTeam:masterfrom
ninstar:thextech-smbx

Conversation

@ninstar

@ninstar ninstar commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

TheXTech (left) and SMBX (right)

preview

@varlesh

varlesh commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

why you fix white color? #e4e4e4 color used ONLY for background, for elements you can use normal white color, like a '#ffffff'
You icon not use pixel perfect align, it's our HIG. Enable this on Inkscape and fix Shift + 3
image

@ninstar

ninstar commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

why you fix white color? #e4e4e4 color used ONLY for background, for elements you can use normal white color

For consistency with existing icons, like this one that is already in the repository. Also, there doesn't seem to be anything in the design notes explicitly stating that #e4e4e4 should only be used for backgrounds.

You icon not use pixel perfect align, it's our HIG. Enable this on Inkscape and fix Shift + 3 !

Are you comparing the svg from my original post preview or the files in the commit? I checked the files and all nodes making the shape of the element are aligned to the pixel grid, although I now noticed that the mushroom's stem is a few subpixels wider, would that be the issue? if so I can fix it shortly.

@varlesh

varlesh commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

For consistency with existing icons, like this one that is already in the repository. Also, there doesn't seem to be anything in the design notes explicitly stating that #e4e4e4 should only be used for backgrounds.

https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/tools/work/DESIGN.md

Are you comparing the svg from my original post preview or the files in the commit? I checked the files and all nodes making the shape of the element are aligned to the pixel grid, although I now noticed that the mushroom's stem is a few subpixels wider, would that be the issue? if so I can fix it shortly.

It's SVG from inkscape 48px. Take a closer look, not only the mushroom stem has problems with pixel alignment, but also the eyes, the circles on the mushroom cap.

@varlesh

varlesh commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

#e4e4e4 used prefer for backgounds, for other elements you can use any color (except for toxic colors).
Our white #e4e4e4 and black #3f3f3f or #4f4f4f - This is a special limitation for displaying in different color schemes of DE's.

@varlesh

varlesh commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Compare with fixed icon:
image

<svg width="48" height="48" version="1.1" xmlns="http://www.w3.org/2000/svg">
 <path d="m 38,29.29152 v 8.56825 C 38,41.81545 34.877978,45 30.999977,45 H 17.000026 C 13.122,45 10,41.81545 10,37.85977 v -8.56825 c 0,-10.62282 28,-10.62282 28,0 z" style="opacity:.2"/>
 <path d="m38 28.29153v8.56825c0 3.95568-3.122022 7.14023-7.000023 7.14023h-13.999951c-3.878026 0-7.000026-3.18455-7.000026-7.14023v-8.56825c0-10.62282 28-10.62282 28 0z" style="fill:#f0c3a5"/>
 <path d="m24.00001 5c-11.079996 0-19.999994 6.32715-19.999994 14.18906 0 0.0695 5e-3 0.14095 5e-3 0.20992-0.0011 0.0505-5e-3 0.10072-5e-3 0.15145v9.72782c0 3.65219 2.46861 6.63524 5.999984 7.07258v-1.98672c0-2.42285 2.201264-4.36412 4.625013-4.36412h18.74999c2.42375 0 4.624997 1.94127 4.624997 4.36412v1.98657c3.53138-0.43729 6.000003-3.42039 6.000003-7.07258v-9.72782c0-0.0507-5e-3 -0.10072-5e-3 -0.15145 1e-3 -0.0692 5e-3 -0.14069 5e-3 -0.20992 0-7.86176-8.92-14.18891-19.999993-14.18891z" style="opacity:.1"/>
 <path d="m19.500014 26.57566c0.831 0 1.499986 0.63691 1.499986 1.42804v8.56825c0 0.79113-0.668986 1.42805-1.499986 1.42805-0.831028 0-1.500014-0.63692-1.500014-1.42805v-8.56825c0-0.79113 0.668986-1.42804 1.500014-1.42804z" style="fill:#3f3f3f"/>
 <path d="M 28.499999,26.57566 C 29.330994,26.57566 30,27.21257 30,28.0037 v 8.56825 C 30,37.36308 29.330994,38 28.499999,38 27.669005,38 27,37.36308 27,36.57195 V 28.0037 c 0,-0.79113 0.669005,-1.42804 1.499999,-1.42804 z" style="fill:#3f3f3f"/>
 <path d="m24.00001 4.00001c-11.079996 0-19.999994 6.32715-19.999994 14.18906 0 0.0695 5e-3 0.14095 5e-3 0.20992-0.0011 0.0505-5e-3 0.10072-5e-3 0.15145v9.72782c0 3.65219 2.46861 6.63524 5.999984 7.07258v-1.98672c0-2.42285 2.201264-4.36412 4.625013-4.36412h18.74999c2.42375 0 4.624997 1.94127 4.624997 4.36412v1.98657c3.53138-0.43729 6.000003-3.42039 6.000003-7.07258v-9.72782c0-0.0507-5e-3 -0.10072-5e-3 -0.15145 1e-3 -0.0692 5e-3 -0.14069 5e-3 -0.20992 0-7.86176-8.92-14.18891-19.999993-14.18891z" style="fill:#ff3137"/>
 <path d="m21.136719 5.1445312c-2.996331 0.3024879-5.775931 1.0719157-8.185547 2.203125 0.670251 1.9845786 2.161902 3.6523438 3.90625 3.6523438 2.337539 0 4.221388-2.7591593 4.279297-5.8554688zm5.726562 0c0.05791 3.0963095 1.941758 5.8554688 4.279297 5.8554688 1.744348 0 3.235999-1.6677652 3.90625-3.6523438-2.409616-1.1312093-5.189216-1.9006372-8.185547-2.203125zm13.28711 5.6562498c-2.688456 0.467798-5.150391 2.797694-5.150391 5.623047v2.794922c0 3.164541 2.976865 5.712891 6.142578 5.712891 1.043497 0 2.017205-0.28129 2.857422-0.765625v-4.617188c0-0.05084-0.0048-0.09983-0.0059-0.15039 0.001441-0.069121 0.0059-0.13763 0.0059-0.207032 0-3.144778-1.427849-6.043295-3.849609-8.390625zm-32.355469 0.056641c-2.3873936 2.337619-3.7949219 5.213797-3.7949219 8.333984 0 0.0694 0.00444 0.137915 0.00586 0.207032-0.0010506 0.05055-0.00586 0.099554-0.00586 0.15039v4.679688c0.8402169 0.484477 1.8139251 0.763671 2.8574219 0.763672 3.1657131 0 6.1425781-2.546397 6.1425781-5.710938v-2.794922c0-2.844546-2.489396-5.183529-5.2050781-5.628906zm14.705078 3.142578c-4.155 0-7.5 3.122-7.5 7s3.345 7 7.5 7h3c4.155 0 7.5-3.122 7.5-7s-3.345-7-7.5-7z" style="opacity:.2"/>
 <path d="m21.136719 4.1445312c-2.996331 0.3024879-5.775931 1.0719157-8.185547 2.203125 0.670251 1.9845786 2.161902 3.6523438 3.90625 3.6523438 2.337539 0 4.221388-2.7591593 4.279297-5.8554688zm5.726562 0c0.05791 3.0963095 1.941758 5.8554688 4.279297 5.8554688 1.744348 0 3.235999-1.6677652 3.90625-3.6523438-2.409616-1.1312093-5.189216-1.9006372-8.185547-2.203125zm13.28711 5.65625c-2.688456 0.4677978-5.150391 2.7976938-5.150391 5.6230468v2.794922c0 3.164541 2.976865 5.712891 6.142578 5.712891 1.043497 0 2.017205-0.28129 2.857422-0.765625v-4.617188c0-0.05084-0.004759-0.099834-0.005859-0.15039 0.0014-0.069121 0.005859-0.13763 0.005859-0.207032 0-3.144778-1.427849-6.043295-3.849609-8.3906248zm-32.355469 0.0566407c-2.3873936 2.3376191-3.7949219 5.2137971-3.7949219 8.3339841 0 0.0694 0.0044394 0.137915 0.0058594 0.207032-0.00105 0.05055-0.0058594 0.099554-0.0058594 0.15039v4.679688c0.8402169 0.484477 1.8139251 0.763671 2.8574219 0.763672 3.1657131 0 6.1425781-2.546397 6.1425781-5.710938v-2.794922c0-2.844546-2.489396-5.183529-5.2050781-5.6289061zm14.705078 3.1425781c-4.155 0-7.5 3.122-7.5 7s3.345 7 7.5 7h3c4.155 0 7.5-3.122 7.5-7s-3.345-7-7.5-7h-3z" style="fill:#ffffff"/>
 <path d="m24.000003 4c-11.079996 0-20 6.32754-20 14.18945 0 0.0695 0.0059 0.14002 0.0059 0.20899-0.0011 0.0505-0.0059 0.10161-0.0059 0.15234v0.63867c0-7.86191 8.920004-14.18945 20-14.18945 11.07999 0 20 6.32769 20 14.18945v-0.63867c0-0.0507-6e-3 -0.10161-6e-3 -0.15234 1e-3 -0.0692 6e-3 -0.13976 6e-3 -0.20899 0-7.86176-8.92001-14.18945-20-14.18945zm20 15.18945c0 0.0692-5e-3 0.13979-6e-3 0.20899 0 0.0507 6e-3 0.10164 6e-3 0.15234zm-40 0v0.36133c0-0.0507 0.0048-0.10184 0.0059-0.15234 0-0.069-0.0059-0.13949-0.0059-0.20899z" style="fill:#ffffff;opacity:.2"/>
</svg>

@varlesh

varlesh commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

As for shadows, we usually use 20%, but if the element is darker than the background, then the shadow will be 10%. In the corrected icon, I did it. please note that the mushroom cap is darker than the leg, so its shadow is 10%

@varlesh

varlesh commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Example:
image

@ninstar

ninstar commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

Should be good now.

@varlesh
varlesh merged commit 1369801 into PapirusDevelopmentTeam:master Apr 29, 2025
@varlesh

varlesh commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

ok, i fix some elements

varlesh added a commit that referenced this pull request Apr 29, 2025
@varlesh
fix icons #4033
7343f79
@ninstar
ninstar deleted the thextech-smbx branch January 29, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ninstar @varlesh