Unified symbolic icons by SmartFinn · Pull Request #3983 · PapirusDevelopmentTeam/papirus-icon-theme

SmartFinn · 2025-03-12T09:25:02Z

This PR makes the monochrome icons equal to symbolic icons and vice versa. It also removes symbolic icons from Papirus-Dark icon theme that was added as a workaround for DEs without symbolic icons support. In recent years, many apps and DEs have moved to GTK3+, so it seems like a good time to remove this workaround.

Checklist

Delete symbolic icons from Papirus-Dark
Inject KDE Color Scheme into symbolic icons
Add symbolic specific CSS classes to monochrome icons
Add symbolic icons for 22px, 24px, 32px sizes
- Move monochrome icons with -symbolic suffix to 22x22/symbolic and 24x24/symbolic directories
- Create symlinks to 22x22/symbolic and 24x22/symbolic directories in the child themes
- Add 32x32/symbolic directory as a symlink to 16x16/symbolic
- Update index.theme
Update scripts

This change makes the monochrome icons equal to symbolic icons

This commit starts the merging of symbolic icons with Papirus.

* dirty change to keep linear git history

…early

ePapirus/16x16/actions/window-* kept as is ePapirus-Dark/16x16/actions/window-* kept as is

* Remove duplicates that already exists in other context * Update symbolic/device/multimedia-player-symbolic.svg from panel icon

These themes should be functional before delete to allow easily restore.

This change allows us to get 32px symbolic icons by scaling 16px icons twice.

varlesh · 2025-03-15T16:04:07Z

@SmartFinn Ты бы уже остановился) Я сделаю все остальное из своего бранча. 16px/symbolic не буду трогать, тут и без него куча проблем

SmartFinn · 2025-03-15T16:06:34Z

@varlesh I'm merging commits from your branch with this one in this branch https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/tree/the-merge. It's not taking a long time.

varlesh · 2025-03-15T16:08:04Z

@SmartFinn Ненужно. Я еще сам пока много что тестирую... Что будем делать с 32/panel? Ее надо удалить по хорошему

varlesh · 2025-03-15T16:09:48Z

@SmartFinn 32px/symbolic пока под вопросом. Если они GTK ненужны, то надо смотреть что там KDE уже решит по их поводу. но думаю пока не стоит их удалять

SmartFinn · 2025-03-15T16:11:22Z

@varlesh I'm not going to merge something that looks like testing staff.

Что будем делать с 32/panel? Ее надо удалить по хорошему

Yeah, this workaround spawns several conflicts.

varlesh · 2025-03-15T16:11:24Z

Если всё норм, сливай этот бранч. Чего ждать-то.... Один фиг чё-нить еще вылезет))

varlesh · 2025-03-15T16:13:04Z

Да, сноси ее. Это костыль ненужный. С симболик 32 потом решим

varlesh · 2025-03-15T16:17:17Z

Мейнтейнерам наверное надо стукнуть перед слиянием токо

SmartFinn · 2025-03-15T16:22:55Z

Мейнтейнерам наверное надо стукнуть перед слиянием токо

@varlesh as I can see, there are no conflicts at all. Do you have papirus-icon-theme package installed from ppa:papirus/papirus-dev? If the package upgrades smoothly, that's meaning anything is okay.

varlesh · 2025-03-15T16:25:35Z

@SmartFinn Я на арче уже давно)) Я про то, что кто может собирает Git-версии, может у них вылезти проблемы или нет. Просто мало ли кто как собирает, через makefile или еще как

varlesh · 2025-03-15T16:41:33Z

@SmartFinn Список мейнтейнеров, вроде они
@markand @sibskull @felixonmars @yangfl @hwittenborn @eclipseo @tagattie @ScardracS @Aleksanaa @curantes @fedya @JoshStrobl @gfrr

mochaaP · 2025-09-07T14:59:18Z

Delete symbolic icons from Papirus-Dark

I think we still want symbolic icons in Papirus-Dark as a fallback, due to .ColorScheme-xx classes only being recolored in applications using KIconThemes both directly or indirectly via a platform theme like plasma-integration which will pull in the whole KDE Plasma stack. The worst scenario is a closed-source, statically linked Qt application so we can't even use a platform theme.

Take fcitx5-config-qt as an example:

Old behavior:

New behavior:

cc @SmartFinn

mochaaP · 2025-09-07T16:42:58Z

indirectly via a platform theme like plasma-integration

A workaround for qt5ct / qt6ct users is to use these patches:
https://aur.archlinux.org/cgit/aur.git/tree/qt5ct-shenanigans.patch?h=qt5ct-kde
https://www.opencode.net/trialuser/qt6ct/-/merge_requests/9
(see qt5ct-kde and qt6ct-kde on AUR)

SmartFinn added 6 commits March 12, 2025 19:57

Move symbolic directory into 16x16 folder

abe21cb

Update scripts to support the new location of symbolic icons

bcf1964

Add success, warning, and error classes to monochrome icons

090bfc7

This change makes the monochrome icons equal to symbolic icons

Delete symbolic icons from Papirus-Dark theme (1/2)

e32a152

This commit starts the merging of symbolic icons with Papirus.

Add symbolic symlinked directory to Papirus-Dark (2/2)

e887a72

Add KDE ColorScheme to symbolic icons #3663

d7fb390

SmartFinn changed the base branch from new-directory-structure to master March 13, 2025 16:05

SmartFinn force-pushed the unified-symbolic-icons branch from 764cef1 to d7fb390 Compare March 13, 2025 16:06

SmartFinn added 17 commits March 14, 2025 12:02

Delete *-symbolic symlinks from 16x16/panel that exists in symbolic

3fab55d

Move 24x24/actions/*-symbolic icons from ePapirus

6f1ae66

* dirty change to keep linear git history

Move 24x24/panel/*-symbolic icons and broken symlinks from ePapirus

13dcb14

* dirty change to keep linear git history

Add KDE ColorScheme to symbolic icons moved from ePapirus

e8c1753

Move 22x22/actions/*-symbolic symlinks to 22x22/symbolic/actions

3297c5b

* dirty change to keep linear git history

Move 16x16/panel/*-symbolic icons and symlinks to 16x16/symbolic/status

8960aa7

* dirty change to keep linear git history

Move 22x22/panel/*-symbolic icons and symlinks to 22x22/symbolic/status

1e24271

* dirty change to keep linear git history

Delete 24x24/panel/*-symbolic because they were copied from ePapirus …

d907791

…early

Remove *-symbolic icons and symlinks from child themes

3cfb872

ePapirus/16x16/actions/window-* kept as is ePapirus-Dark/16x16/actions/window-* kept as is

Fix sizes notation in new-symlink.sh script

dd31039

Fix broken symlinks in Papirus/*/symbolic/* dirs

dc8fa5e

Move some icons from symbolic/status to the right context

4dc72bb

* Remove duplicates that already exists in other context * Update symbolic/device/multimedia-player-symbolic.svg from panel icon

Add 22x22/symbolic and 24x24/symbolic to index.theme

e809a75

Add 24x24/symbolic to ePapirus and ePapirus-Dark

1c5302c

These themes should be functional before delete to allow easily restore.

Add symlink 32x32/symbolic -> 16x16/symbolic, and update index.theme

a01ed14

This change allows us to get 32px symbolic icons by scaling 16px icons twice.

Deny convert symbolic icons for child themes

5c9eafb

Add GNOME symbolic classes to all icons with KDE Color Scheme

bca3d44

SmartFinn merged commit b2e2de1 into master Mar 15, 2025

varlesh mentioned this pull request Mar 16, 2025

Icons in Plasma 6 are dark-on-dark #3964

Closed

SmartFinn deleted the unified-symbolic-icons branch March 16, 2025 11:16

kajusnau mentioned this pull request Jun 11, 2025

bump: update to the latest tiiuae/ghaf#1235

Merged

18 tasks

Uh oh!

Uh oh!

Conversation

SmartFinn commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

varlesh commented Mar 15, 2025

Uh oh!

SmartFinn commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varlesh commented Mar 15, 2025

Uh oh!

varlesh commented Mar 15, 2025

Uh oh!

SmartFinn commented Mar 15, 2025

Uh oh!

varlesh commented Mar 15, 2025

Uh oh!

varlesh commented Mar 15, 2025

Uh oh!

varlesh commented Mar 15, 2025

Uh oh!

SmartFinn commented Mar 15, 2025

Uh oh!

varlesh commented Mar 15, 2025

Uh oh!

varlesh commented Mar 15, 2025

Uh oh!

mochaaP commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mochaaP commented Sep 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SmartFinn commented Mar 12, 2025 •

edited

Loading

SmartFinn commented Mar 15, 2025 •

edited

Loading

mochaaP commented Sep 7, 2025 •

edited

Loading