Add a script to find missing mimetypes icons. - #3952
Merged
SmartFinn merged 2 commits intoMar 17, 2025
Conversation
Contributor
Author
|
First question is: is this helper script in the right folder? 😁 |
Member
|
Wow! It's brilliant! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #3904, I found myself wanting a script for discovering MIME types that don't have icons or symlinks yet. I thought I'd make one. This script scans the cached bits of the shared-mime-info database on the local device, and checks whether icons exist in the Papirus tree for those.
The idea is that only devs will use it; it's not part of any workflow, since it produces rather a lot of false positive output. By default, it flags anything defaulting to
<type>-x-genericas a potential omission, after considering 1) named icons for the mimetype, 2) fallback icons for the exact mimetype string, and 3) named generic icons for the mimetype. Quite often, that's fine; at other times it's an indication that Papirus needs a more specific icon for the mimetype.Ref:
-formimetypes)Leaving this open for review for a bit.