Skip to content

Add RenderDoc Icon - #3785

Closed
chadowo wants to merge 2 commits into
PapirusDevelopmentTeam:masterfrom
chadowo:add-renderdoc-icon
Closed

Add RenderDoc Icon#3785
chadowo wants to merge 2 commits into
PapirusDevelopmentTeam:masterfrom
chadowo:add-renderdoc-icon

Conversation

@chadowo

@chadowo chadowo commented Jul 15, 2024

Copy link
Copy Markdown
Contributor

RenderDoc is a free and open source graphics debugger for D3D11, D3D12, OpenGL & OpenGL ES or Vulkan that runs on Windows, Linux, Android & Nintendo Switch.

Original logo:
RenderDoc logo

@morganist

Copy link
Copy Markdown
Member

hi!
can you please better align the logo to the pixel grid and change the background colour to the one from Papirus examples?

below the logo and (I hope) fix incorrect alignment on
pixel grid
@chadowo

chadowo commented Sep 28, 2024

Copy link
Copy Markdown
Contributor Author

Does 243ae13 fix the problem? I also added a little shadow below the logo seeing a lot of other logos have it in Papirus.

@morganist

morganist commented Oct 12, 2024

Copy link
Copy Markdown
Member

well, it looks better now!

consider these steps next:

make the highlighted edges of the logo align to the pixel grid. this way the logo would be crisp and legible. please don't forget to repeat this for every size and make the same changes th the shadow.

image

also, you could try and make the shadow under the logo more opaque: for instance, give it an opacity of 20 instead of 10. i feel this would make the logo stand out more on the light-green background

@achadwick

Copy link
Copy Markdown
Contributor

I'll grab this and add a fixups branch.

Colour notes: this is the Papirus green from the apps templates, and I felt that it is too bright for a white logo. I checked on WebAIM, and indeed it does not pass the bare minimum WCAG AA rating for graphical objects and user interface elements. That isn't a requirement yet for Papirus, but it's something we probably ought to consider.

It's also a different hue from the example, but not by much. I'll consider

#79DE7D#2BAB2F Papirus Template Green. I feel it's a little saturated.
#3BB779#36A66E RenderDoc Logo Green. Closer to the original. This feels better to me.

achadwick added a commit to achadwick/papirus-icon-theme that referenced this pull request Jan 31, 2025
@achadwick

Copy link
Copy Markdown
Contributor

OK, my version's in https://github.com/achadwick/papirus-icon-theme/tree/pr3785-redraw. @morganist: are you able to review? I think it's nicely aligned and good to merge.

I snubbed the ends of the arc at smaller sizes. I think it sells the ends of the curved line better at the small pixel renderings than letting them taper. 64 and 48 I've left alone, and drawn as accurately as I can, since those are the ones that might end up getting upscaled.

Firmer in my opinion that the template green is really not right for this; it needs far higher contrast with the white.

@morganist

morganist commented Jan 31, 2025 via email

Copy link
Copy Markdown
Member

@achadwick achadwick mentioned this pull request Jan 31, 2025
@achadwick

Copy link
Copy Markdown
Contributor

@achadwick i'll review all your fixups today evening, just in time for the release. hopefully you've allowed commits from maintainers on your fork.

Thanks. I've had to make new PRs for the ones that didn't have them, just so I can turn on the flag.

@chadowo

chadowo commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

@achadwick thank you so much for fixing up this PR.

I'm ashamed to say I forgot about this PR. Creating the icon was fairly harder than I thought it would be, you people rock!

I'll close this PR now since it's superseded by #3942. Again, thank you both for your time, @morganist @achadwick :-)

@chadowo chadowo closed this Jan 31, 2025
achadwick added a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants