Code Generation for TypedKeys #9233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2023
|
I'm curious, is there any better way to have auto-generated files in some sort of their own module that can be merged with the API one, therefore doesn't need to use the patch system? Not sure tho. |
|
dependencies are gonna be fun if we do that |
Machine-Maker
force-pushed
the
feature/key-generation
branch
2 times, most recently
from
4da5e26 to
35dd374
Compare
|
Looking at this so far, no real qualms against it, and generally looks like what I'd expect in regards to output, etc; only thing is the create methods, I'm guessing that there is still a bit of wiring up to do there |
Machine-Maker
force-pushed
the
feature/key-generation
branch
3 times, most recently
from
bd161b8 to
ca10f05
Compare
MiniDigger
approved these changes
Jun 9, 2023
Machine-Maker
force-pushed
the
feature/key-generation
branch
from
ca10f05 to
d331027
Compare
Machine-Maker
force-pushed
the
feature/key-generation
branch
from
d331027 to
b39c29d
Compare
19 tasks
Machine-Maker
force-pushed
the
feature/key-generation
branch
3 times, most recently
from
50f4743 to
e11fab5
Compare
kennytv
reviewed
Sep 30, 2023
kennytv
approved these changes
Sep 30, 2023
Machine-Maker
force-pushed
the
feature/key-generation
branch
4 times, most recently
from
adea1f6 to
f0be001
Compare
Owen1212055
approved these changes
Nov 18, 2023
Owen1212055
force-pushed
the
feature/key-generation
branch
from
f0be001 to
4763950
Compare
Machine-Maker
force-pushed
the
feature/key-generation
branch
2 times, most recently
from
5ae6266 to
ee5f94a
Compare
Machine-Maker
force-pushed
the
feature/key-generation
branch
2 times, most recently
from
ba70fdf to
c86bba7
Compare
Currently includes generated key holder classes for types used in the Registry Modification API
Machine-Maker
force-pushed
the
feature/key-generation
branch
from
c86bba7 to
715fa94
Compare
lynxplay
pushed a commit
to lynxplay/paper
that referenced
this pull request
Feb 23, 2024
Currently includes generated key holder classes for types used in the Registry Modification API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently includes generated key holder classes for types
used in the Registry Modification API
Tasks
I think its acceptable that this is a manual thing, and the generated code just goes into a patch file, rather than being created for each applyPatches. Once we have source in repo, it won't be a large patch. Its also just one less build step
The reason why this is needed, and really should only be used in conjunction with the Registry Modification API, is that you have to specify the key of any value you want to modify, but you cannot use the API object itself to get the key, like for
GameEvent. If you wanted to modify the range of a specificGameEvent, you can't get the key fromGameEvent.BLOCK_OPEN.getKey(), because the Registry Modification API runs before those objects can be created. So doing that will throw an exception. So we haveGameEventKeyswhich will hold some sort of TypedKey object that you can use instead. Of course for custom ones, you can create your own keys.