Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item datacomponent api #10845

Merged
merged 66 commits into from
Nov 18, 2024
Merged

Item datacomponent api #10845

merged 66 commits into from
Nov 18, 2024

Conversation

Owen1212055
Copy link
Member

@Owen1212055 Owen1212055 commented Jun 2, 2024

Tasks

Preview Give feedback
  1. build-pr-jar priority: high
name primitive? Implemented?
custom_data
max_stack_size
max_damage
damage
unbreakable
custom_name
item_name
item_model
lore
rarity
enchantments
can_place_on
can_break
attribute_modifiers
custom_model_data
hide_additional_tooltip
hide_tooltip
repair_cost
creative_slot_lock
enchantment_glint_override
intangible_projectile
food
consumable
use_remainder
use_cooldown
damage_resistant
tool
enchantable
equippable
repairable
glider
tooltip_style
death_protection
stored_enchantments
dyed_color
map_color
map_id
map_decorations
map_post_processing
bundle_contents
potion_contents
suspicious_stew_effects
writable_book_content
written_book_content
trim
debug_stick_state
entity_data
bucket_entity_data
block_entity_data
instrument
ominous_bottle_amplifier
jukebox_playable
recipes
lodestone_tracker
firework_explosion
fireworks
profile
note_block_sound
banner_patterns
base_color
pot_decorations
container
block_state
  • (partially)
bees
lock
container_loot

@Owen1212055 Owen1212055 requested a review from a team as a code owner June 2, 2024 18:41
@Owen1212055 Owen1212055 mentioned this pull request Jun 2, 2024
@Machine-Maker Machine-Maker force-pushed the item-datacomponent-api branch from ab97e06 to 08c01fb Compare June 3, 2024 19:00
@Machine-Maker Machine-Maker changed the base branch from master to feature/ItemStack-proxy June 3, 2024 19:09
@Machine-Maker Machine-Maker force-pushed the feature/ItemStack-proxy branch 7 times, most recently from 5f8b360 to 55fb24b Compare June 17, 2024 17:48
Base automatically changed from feature/ItemStack-proxy to dev/1.21 June 17, 2024 19:12
@kennytv kennytv changed the base branch from dev/1.21 to master June 17, 2024 19:25
@Owen1212055 Owen1212055 force-pushed the item-datacomponent-api branch from 8a23207 to 4414a61 Compare June 17, 2024 19:55
new file mode 100644
index 0000000000000000000000000000000000000000..54e1a383c4eeb595417ea6e9e4e9527a8ffd9a99
--- /dev/null
+++ b/src/main/java/io/papermc/paper/util/Filtered.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Util doesn't feel like the right package for this. It's not a general utility, it's a Minecraft type

@lynxplay lynxplay force-pushed the item-datacomponent-api branch 2 times, most recently from db51a8a to 3e6d2ad Compare November 18, 2024 16:21
@Owen1212055 Owen1212055 force-pushed the item-datacomponent-api branch from f0399cc to dd9d6ad Compare November 18, 2024 19:51
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved under the expectations that more javadocs and toBuilder methods will follow in a upcoming PR.

@Owen1212055 Owen1212055 merged commit de6173b into master Nov 18, 2024
5 checks passed
@Owen1212055 Owen1212055 deleted the item-datacomponent-api branch November 18, 2024 20:09
@TheBentoBox
Copy link

Just saw this in the latest Paper build, just wanted to say huge thanks for the work here. Was hoping for something exactly like this from upstream but as usual the Paper team/contributors pull through 😎 Kudos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

9 participants