Skip to content

fix the error of defined more than once #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juncaipeng merged 3 commits into from
Jun 14, 2023
Merged

fix the error of defined more than once #3318

juncaipeng merged 3 commits into from
Jun 14, 2023

Conversation

@EmmonsCurse
Copy link
Contributor

@EmmonsCurse EmmonsCurse commented Jun 12, 2023

PR types

Bug fixes

PR changes

Others

Description

fix the ERROR: "flag 'devices' or 'use_mkldnn' was defined more than once" in cpp inference to adapt the change of Paddle.
37091a405e36be4eff796689ead2e1d7

  1. 'devices' was defined twice in https://github.com/PaddlePaddle/Paddle/blob/64ecdc03db38377e37a1c149086c1eb8700c3e04/paddle/fluid/inference/io.cc#L32 and

    PaddleSeg/deploy/cpp/src/test_seg.cc

    Line 19 in 92ab2be

    DEFINE_string(devices, "GPU", "Use GPU or CPU devices. Default: GPU");
  2. 'use_mkldnn' was defined twice in https://github.com/PaddlePaddle/Paddle/blob/64ecdc03db38377e37a1c149086c1eb8700c3e04/paddle/phi/core/flags.cc#LL682C30-L682C30 and

    PaddleSeg/deploy/cpp/src/test_seg.cc

    Line 24 in 92ab2be

    DEFINE_bool(use_mkldnn, false, "Wether enable MKLDNN when use CPU. Defualt: false.");

juncaipeng
juncaipeng previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juncaipeng juncaipeng merged commit 2360fb4 into PaddlePaddle:develop Jun 14, 2023
EmmonsCurse added a commit to EmmonsCurse/PaddleSeg that referenced this pull request Jun 15, 2023
@EmmonsCurse
Revert "[Fix] fix the error of defined more than once (PaddlePaddle#3318
f1d116c 
)"

This reverts commit 2360fb4.
@EmmonsCurse EmmonsCurse mentioned this pull request Jun 15, 2023
Merged
juncaipeng pushed a commit that referenced this pull request Jun 15, 2023
@EmmonsCurse
Revert "[Fix] fix the error of defined more than once (#3318)" (#3325)
0952e33 
This reverts commit 2360fb4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juncaipeng juncaipeng juncaipeng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmmonsCurse @juncaipeng