Skip to content

Conversation

@zty-king
Copy link
Contributor

@zty-king zty-king commented Oct 18, 2025

PR Category

User Experience

PR Types

New features

Description

  1. support hf checkpoint and add test
  2. add aoa primitives test about add and cast
  3. star_macro在匹配时需要严格匹配,否则匹配某个weight时,会把优化器状态也匹配进去。做了修复
image

xingmingyyj and others added 2 commits October 17, 2025 16:27
@paddle-bot
Copy link

paddle-bot bot commented Oct 18, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 18, 2025
@xingmingyyj
Copy link
Contributor

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 91.81818% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@945ea69). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...n/paddle/distributed/flex_checkpoint/aoa/macros.py 93.02% 6 Missing ⚠️
...ddle/distributed/flex_checkpoint/aoa/aoa_engine.py 50.00% 4 Missing ⚠️
...distributed/flex_checkpoint/dcp/load_state_dict.py 82.35% 3 Missing ⚠️
...on/paddle/distributed/flex_checkpoint/dcp/utils.py 96.00% 3 Missing ⚠️
...ddle/distributed/flex_checkpoint/dcp/full_param.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #75928   +/-   ##
==========================================
  Coverage           ?   91.81%           
==========================================
  Files              ?        5           
  Lines              ?      220           
  Branches           ?        0           
==========================================
  Hits               ?      202           
  Misses             ?       18           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zty-king
Copy link
Contributor Author

/re-run all-failed

1 similar comment
@zty-king
Copy link
Contributor Author

/re-run all-failed

@xingmingyyj
Copy link
Contributor

/re-run all-failed

1 similar comment
@zty-king
Copy link
Contributor Author

/re-run all-failed

@zty-king zty-king force-pushed the pr-support_load_hf_checkpoint branch from 55bc6ba to 186beeb Compare October 23, 2025 04:34
@zty-king
Copy link
Contributor Author

/re-run all-failed

Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 1fd2b5a into PaddlePaddle:develop Oct 27, 2025
90 of 93 checks passed
xingmingyyj added a commit to xingmingyyj/Paddle that referenced this pull request Nov 5, 2025
* support hf checkpoint

fix

support cast

add id macro

fix

* add test and fix some bug

* fix full param bug

* add full param cast test

---------

Co-authored-by: xingmingyyj <[email protected]>
xingmingyyj added a commit to xingmingyyj/Paddle that referenced this pull request Nov 5, 2025
* support hf checkpoint

fix

support cast

add id macro

fix

* add test and fix some bug

* fix full param bug

* add full param cast test

---------

Co-authored-by: xingmingyyj <[email protected]>
From00 pushed a commit that referenced this pull request Nov 6, 2025
…#76252)

* 【FlexCheckpoint】fix_the_layer_id_macro (#75556)

* fix_the_layer_id_macro

* fix the ctest

* add expert_id_macro

* fix the assert bug

* fix the code style

* Pr support load hf checkpoint (#75928)

* support hf checkpoint

fix

support cast

add id macro

fix

* add test and fix some bug

* fix full param bug

* add full param cast test

---------

Co-authored-by: xingmingyyj <[email protected]>

* 【Flexcheckpoint】add_get_var_mapping_chain_macro (#76013)

* add_get_var_mapping_chain_macro

* add note

* fix the bug input_vars and resolve_mapping_chain

* fix the code style

* fit the dtype assert bug

* fix the bug

* fix the merge_sharded_state_dict bug

* fix aoa transpose corner case (#76234)

---------

Co-authored-by: Tianyu Zheng <[email protected]>
sneaxiy pushed a commit that referenced this pull request Nov 6, 2025
….2 (#76249)

* 【FlexCP】merge_sharded_state_dict support distribute merge (#75005)

* fix data is nullptr

* add dist merge

* change test

* change test

* 【FlexCP】add Skip param param for merge_shard_state_dict (#75061)

* fix data is nullptr

* add dist merge

* change test

* change test

* add skip optimizer param

* [Flex CP]Fix merge_sharded_state_dict with aoa and offload (#75062)

* fix merge_state_dict with aoa and offload

* add tests

* refine

* fix

* fix

* add log

* fix

* fix

* 【FlexCheckpoint】Upgrade some macros and optimize load_state_dict communication (#75282)

* upgrad macros and load_state_dict comm task

fix

fix

support 0-d tensor

fix

balance save and fix

* fix test

* Add the test about the sharded_state_dict of optimizer  (#75067)

* fix the share_weight_bug

* add note

* add the unit test

* set the timeout

* add more test

* Trigger CI rebuild

* fix the CmakeLists

* handle_missing_edge_cases_in_fc (#75413)

* up_grade fc (#75613)

fix and add test

fix

fix

fix

fix cmakelists

add notion

* 【FlexCheckpoint】fix_the_layer_id_macro (#75556)

* fix_the_layer_id_macro

* fix the ctest

* add expert_id_macro

* fix the assert bug

* fix the code style

* Pr support load hf checkpoint (#75928)

* support hf checkpoint

fix

support cast

add id macro

fix

* add test and fix some bug

* fix full param bug

* add full param cast test

---------

Co-authored-by: xingmingyyj <[email protected]>

* 【Flexcheckpoint】add_get_var_mapping_chain_macro (#76013)

* add_get_var_mapping_chain_macro

* add note

* fix the bug input_vars and resolve_mapping_chain

* fix the code style

* fit the dtype assert bug

* fix the bug

* fix the merge_sharded_state_dict bug

* fix aoa transpose corner case (#76234)

---------

Co-authored-by: xiaoguoguo626807 <[email protected]>
Co-authored-by: Chen Zhiyang <[email protected]>
Co-authored-by: Tianyu Zheng <[email protected]>
@zty-king zty-king deleted the pr-support_load_hf_checkpoint branch November 23, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants