【FlexCheckpoint】fix_the_layer_id_macro #75556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #75556 +/- ##
==========================================
Coverage ? 94.28%
==========================================
Files ? 2
Lines ? 35
Branches ? 0
==========================================
Hits ? 33
Misses ? 2
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
/re-run all-failed |
xingmingyyj
reviewed
Oct 9, 2025
test/flex_checkpoint/test_macros.py
Outdated
| return "fused_qkv_old_macro" | ||
|
|
||
| def source_code(self): | ||
| return "layers.1.self_attn.qkv_proj.bias -> layers.1.self_attn.qkv_proj.bias, fused_qkv_old, num_heads = 8, num_key_value_groups = 4, axis = 0" |
Contributor
There was a problem hiding this comment.
layers.1.self_attn.qkv_proj.bias，bias通常是一维的，这里为了适配这种情况所以传入了参数axis = 0
Contributor
Author
|
/re-run all-failed |
Contributor
|
LGTM |
zty-king
changed the title
Contributor
|
LGTM |
From00
approved these changes
Oct 15, 2025
xingmingyyj
pushed a commit
to xingmingyyj/Paddle
that referenced
this pull request
Nov 5, 2025
* fix_the_layer_id_macro * fix the ctest * add expert_id_macro * fix the assert bug * fix the code style
xingmingyyj
pushed a commit
to xingmingyyj/Paddle
that referenced
this pull request
Nov 5, 2025
* fix_the_layer_id_macro * fix the ctest * add expert_id_macro * fix the assert bug * fix the code style
From00
pushed a commit
that referenced
this pull request
Nov 6, 2025
…#76252) * 【FlexCheckpoint】fix_the_layer_id_macro (#75556) * fix_the_layer_id_macro * fix the ctest * add expert_id_macro * fix the assert bug * fix the code style * Pr support load hf checkpoint (#75928) * support hf checkpoint fix support cast add id macro fix * add test and fix some bug * fix full param bug * add full param cast test --------- Co-authored-by: xingmingyyj <[email protected]> * 【Flexcheckpoint】add_get_var_mapping_chain_macro (#76013) * add_get_var_mapping_chain_macro * add note * fix the bug input_vars and resolve_mapping_chain * fix the code style * fit the dtype assert bug * fix the bug * fix the merge_sharded_state_dict bug * fix aoa transpose corner case (#76234) --------- Co-authored-by: Tianyu Zheng <[email protected]>
sneaxiy
pushed a commit
that referenced
this pull request
Nov 6, 2025
….2 (#76249) * 【FlexCP】merge_sharded_state_dict support distribute merge (#75005) * fix data is nullptr * add dist merge * change test * change test * 【FlexCP】add Skip param param for merge_shard_state_dict (#75061) * fix data is nullptr * add dist merge * change test * change test * add skip optimizer param * [Flex CP]Fix merge_sharded_state_dict with aoa and offload (#75062) * fix merge_state_dict with aoa and offload * add tests * refine * fix * fix * add log * fix * fix * 【FlexCheckpoint】Upgrade some macros and optimize load_state_dict communication (#75282) * upgrad macros and load_state_dict comm task fix fix support 0-d tensor fix balance save and fix * fix test * Add the test about the sharded_state_dict of optimizer (#75067) * fix the share_weight_bug * add note * add the unit test * set the timeout * add more test * Trigger CI rebuild * fix the CmakeLists * handle_missing_edge_cases_in_fc (#75413) * up_grade fc (#75613) fix and add test fix fix fix fix cmakelists add notion * 【FlexCheckpoint】fix_the_layer_id_macro (#75556) * fix_the_layer_id_macro * fix the ctest * add expert_id_macro * fix the assert bug * fix the code style * Pr support load hf checkpoint (#75928) * support hf checkpoint fix support cast add id macro fix * add test and fix some bug * fix full param bug * add full param cast test --------- Co-authored-by: xingmingyyj <[email protected]> * 【Flexcheckpoint】add_get_var_mapping_chain_macro (#76013) * add_get_var_mapping_chain_macro * add note * fix the bug input_vars and resolve_mapping_chain * fix the code style * fit the dtype assert bug * fix the bug * fix the merge_sharded_state_dict bug * fix aoa transpose corner case (#76234) --------- Co-authored-by: xiaoguoguo626807 <[email protected]> Co-authored-by: Chen Zhiyang <[email protected]> Co-authored-by: Tianyu Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
这里存在一个问题，一般箭头左边是来自src的key，而箭头右边是来自dst的key，这里的逻辑是先匹配第一个有$LAYER_ID标记的identifier，然而，在get_num_hidden_layers的时候，取的都是dst的key，那么就会发生，如果箭头左右两边的key并不一样，例如qkv->q,k,v时，就会出现key匹配不上的现象，从而返回了一个空的set，导致整个expanded_expressions被返回了一个空列表。