[Distributed] Add PipelineDatasetPreprocessor to aviod mem leaks in pipeline parallel #75446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
/rerun all-failed |
4 similar comments
Contributor
Author
|
/rerun all-failed |
Contributor
Author
|
/rerun all-failed |
Contributor
Author
|
/rerun all-failed |
Contributor
Author
|
/rerun all-failed |
zhangyuqin1998
force-pushed
the
pr/pp_dataset_dev
branch
from
a7fb152 to
c28eab5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #75446 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 1
Lines ? 9
Branches ? 0
===========================================
Hits ? 9
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ForFishes
reviewed
Sep 23, 2025
| micro_batch_data = self._load_micro_batch(self._index) | ||
| self._index += 1 | ||
|
|
||
| if self._index >= self._acc_steps: |
Member
There was a problem hiding this comment.
上面不是已经raise StopIteration，这个判断是否有问题。
This was referenced Sep 23, 2025
Merged
zhangyuqin1998
added a commit
to zhangyuqin1998/Paddle
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Distributed Strategy
PR Types
Improvements
Description
Pass a local function to forward_backward_pipeline instead of the dataset itself. This prevents the dataset from being passed as a direct argument to forward_backward_pipeline, which would create additional reference counts that cannot be cleared, leading to GPU memory leaks.
pcard-76459