Skip to content

fix bug for adaptive_log_softmax_with_loss#73554

Merged
lshpku merged 4 commits into
PaddlePaddle:developfrom
cszdrg:adaptivelogsoftmaxwithloss
Jun 30, 2025
Merged

fix bug for adaptive_log_softmax_with_loss#73554
lshpku merged 4 commits into
PaddlePaddle:developfrom
cszdrg:adaptivelogsoftmaxwithloss

Conversation

@cszdrg
Copy link
Copy Markdown
Contributor

@cszdrg cszdrg commented Jun 23, 2025 •
edited
Loading

PR Category

User Experience

PR Types

Bug fixes

Description

原本的代码
row_indices = label_mask.nonzero().squeeze()
可能产生标量的结果导致接下来unsqueeze(1)失败
进行更改 使得row_indices不再为标量
截屏2025-06-23 16 06 21

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Jun 23, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Jun 23, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@2f56bf4). Learn more about missing BASE report.

⚠️ Current head 2acb7d4 differs from pull request most recent head 92e0917

Please upload reports for the commit 92e0917 to get more accurate results.

Files with missing lines Patch % Lines
python/paddle/nn/functional/loss.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #73554   +/-   ##
==========================================
  Coverage           ?    0.00%           
==========================================
  Files              ?        1           
  Lines              ?        2           
  Branches           ?        0           
==========================================
  Hits               ?        0           
  Misses             ?        2           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cszdrg cszdrg changed the title adaptive_log_softmax_with_loss fix bug for adaptive_log_softmax_with_loss Jun 26, 2025
wanghuancoder
wanghuancoder approved these changes Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lshpku lshpku merged commit f6c8b5a into PaddlePaddle:develop Jun 30, 2025
102 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@lshpku lshpku lshpku approved these changes

Assignees

No one assigned

Labels

contributor External developers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cszdrg @codecov-commenter @wanghuancoder @lshpku