在smooth_l1_loss函数中加入is_huber参数 #73416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: python/paddle/nn/functional/loss.py modified: python/paddle/nn/layer/loss.py modified: test/legacy_test/test_smooth_l1_loss.py
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
当前问题：paddle.nn.SmoothL1Loss和torch.nn.SmoothL1Loss功能不一致。paddle.nn.SmoothL1Loss当前的实现与torch.nn.HuberLoss是一致的。
修改方案：
由于目前paddle的SmoothL1Loss与torch的HuberLoss是一致的，因此无法再增加一个HuberLoss来对应SmoothL1Loss，只能在现有基础上改造，增加is_huber参数：
默认is_huber=True，保持兼容性升级。