[SOT] Add SotCapturedException
#72472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
@SigureMo Please review🫶 |
SigureMo
reviewed
Apr 27, 2025
SigureMo
approved these changes
Apr 28, 2025
Comment on lines
+404
to
+410
| origin_exc: Exception | None = None, | ||
| exc_type: type[Exception] | None = None, | ||
| args: list[Any] | tuple[Any] | None = None, | ||
| context: Exception | None = None, | ||
| cause: Exception | None = None, | ||
| suppress_context: bool | None = None, | ||
| traceback: None = None, |
Member
There was a problem hiding this comment.
这里需要这么多可选值吗？没必要的不建议用可选值，args 有必要用三种类型吗？建议用一种，tuple 类型标注也不对，如果是多个元素应该是 tuple[Any, ...]
SigureMo
changed the title
SotCapturedExceptionSotCapturedException
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
New features
Description
添加
SotCapturedException类，在SOT模拟字节码执行过程中，将所遇到的Exception映射为SotCapturedException，方便SOT对Python异常处理相关字节码的模拟PCard-66972