Skip to content

Conversation

@winter-wang
Copy link
Contributor

@winter-wang winter-wang commented Sep 20, 2023

PR types

New features

PR changes

Others

Description

  1. 支持Trait和Interface的开发者在自己定义的Trait或者Interface里面定义Verify()函数。该Trait或者Interface所附着的operation在Verify的时候,会自动调用该Trait或者Interface的Veriy函数,

  2. 移除了ir.cc中无意义的 OpResult::dyn_cast_from()的调用。

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

2742195759
2742195759 previously approved these changes Sep 20, 2023
Copy link
Contributor

@2742195759 2742195759 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhangboSJTU
zhangboSJTU previously approved these changes Sep 21, 2023
Copy link
Contributor

@zhangboSJTU zhangboSJTU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winter-wang winter-wang dismissed stale reviews from zhangboSJTU and 2742195759 via 78de02e September 21, 2023 07:27
@winter-wang winter-wang force-pushed the ir_develop branch 3 times, most recently from cdde73f to db75571 Compare September 21, 2023 08:29
@winter-wang winter-wang merged commit 1c7c687 into PaddlePaddle:develop Sep 22, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* [PIR] support verify in trait or interface.

* [PIR] fix typo error
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* [PIR] support verify in trait or interface.

* [PIR] fix typo error
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* [PIR] support verify in trait or interface.

* [PIR] fix typo error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants