Modify compare logical inplace #56888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jeff41404
reviewed
Sep 6, 2023
Comment on lines
41
to
44
| void InplaceLogicalKnernelImpl(const Context& dev_ctx, | ||
| const DenseTensor& x, | ||
| const DenseTensor& y, | ||
| DenseTensor* out) { |
Contributor
There was a problem hiding this comment.
why create InplaceLogicalKnernelImpl here while not create in logical_kernel.cc, can we integrate code of LogicalKnernelImpl and InplaceLogicalKnernelImpl into Logical##type##Kernel to maintain the same form as logical_kernel.cc
… modify_compare_logical_inplace
… modify_compare_logical_inplace
jeff41404
approved these changes
Sep 13, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix error * fix compare * fix * fix * remove fluid * fix inpalce test * fix and sep inpalce impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Description
Pcard-75099
set compare and logcial out dtype bool