Skip to content

[NewIR] Insert get_parameter only for paramters#56325

Merged
kangguangli merged 3 commits into
PaddlePaddle:developfrom
kangguangli:fix_program_translator
Aug 16, 2023
Merged

[NewIR] Insert get_parameter only for paramters#56325
kangguangli merged 3 commits into
PaddlePaddle:developfrom
kangguangli:fix_program_translator

Conversation

@kangguangli
Copy link
Copy Markdown
Contributor

@kangguangli kangguangli commented Aug 15, 2023

PR types

Others

PR changes

Others

Description

  1. Strength the requirements for insert a builtin.get_parameter , now only insert for real parameters
  2. For variables created by paddle.static.data or other apis, a pd.data should be inserted instead. For compatibility, we modify the api of paddle.static.data when flag FLAGS_enable_new_ir_in_executor is set.

Others

Pcard-67164

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Aug 15, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Copy Markdown
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyber-pioneer
Copy link
Copy Markdown
Contributor

Lack for description of pr?

@kangguangli
Copy link
Copy Markdown
Contributor Author

Lack for description of pr?

Done

@kangguangli kangguangli merged commit 0f611f1 into PaddlePaddle:develop Aug 16, 2023
@kangguangli kangguangli deleted the fix_program_translator branch August 16, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants