add paddle.optimizer.LBFGS API and a modify its test case test=develop#51912
Merged
Conversation
204e708 to
1bcaa95
Compare
cxxly
reviewed
Apr 7, 2023
Contributor
There was a problem hiding this comment.
functools.reduce(lambda x, y: x*y, x.shape)
cxxly
reviewed
Apr 7, 2023
Contributor
There was a problem hiding this comment.
move all test case into test_lbfgs.py
Contributor
|
add @framework.non_static_only for step |
Contributor
|
copy same version into python/paddle/optimizer/ and add LFBGS into all of init.py |
67190c9 to
29c8145
Compare
Contributor
|
add deprecated for LBFGS in incubate |
990738b to
7788333
Compare
8bc4260 to
f6111ca
Compare
Contributor
|
move all test cast into one file t |
cxxly
reviewed
Apr 24, 2023
Contributor
There was a problem hiding this comment.
import follow pep2 code style, import moudle rather than class/function
XieYunshen
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
Pcard-66961
add paddle.optimizer.LBFGS API
modify numel in _add_grad function to shorten time