Skip to content

[zero-dim] Support 0-d for kthvalue and mode #49122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhwesky2010 merged 3 commits into from
Dec 19, 2022
Merged

[zero-dim] Support 0-d for kthvalue and mode #49122

zhwesky2010 merged 3 commits into from
Dec 19, 2022

Conversation

@zoooo0820
Copy link
Contributor

@zoooo0820 zoooo0820 commented Dec 16, 2022

PR types

New features

PR changes

OPs

Describe

Support 0-d Tensor input for OP kthvalue and mode. Thus, following apis can accept a 0-d Tensor.

paddle.kthvalue
paddle.Tensor.kthvalue
paddle.mode
paddle.Tensor.mode

@paddle-bot
Copy link

paddle-bot bot commented Dec 16, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zoooo0820 zoooo0820 force-pushed the support_0D_for_kthvalue_and_mode branch from e480223 to 0756463 Compare December 16, 2022 12:54
zhwesky2010
zhwesky2010 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 9df0ab3 into PaddlePaddle:develop Dec 19, 2022
@zoooo0820 zoooo0820 deleted the support_0D_for_kthvalue_and_mode branch December 19, 2022 06:20
zoooo0820 added a commit to zoooo0820/Paddle that referenced this pull request Dec 19, 2022
@zoooo0820
Revert "[zero-dim] Support 0-d for kthvalue and mode (PaddlePaddle#49122
de76152 
)"

This reverts commit 9df0ab3.
@zoooo0820 zoooo0820 mentioned this pull request Dec 19, 2022
Merged
@zoooo0820 zoooo0820 restored the support_0D_for_kthvalue_and_mode branch December 19, 2022 09:23
XieYunshen pushed a commit that referenced this pull request Dec 20, 2022
@zoooo0820
Revert "[zero-dim] Support 0-d for kthvalue and mode (#49122)" (#49172)
e4857e0 
This reverts commit 9df0ab3.
@zoooo0820 zoooo0820 mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zoooo0820 @zhwesky2010