Skip to content

Conversation

@wuyujiji
Copy link
Contributor

@wuyujiji wuyujiji commented Oct 21, 2025

Motivation

ci问题修复:
1)https://github.com/PaddlePaddle/FastDeploy/pull/4464/files#diff-d4959610eb1d6eae1c09cf9134b8f7650184b30a359ccd8fe6e192deb5c0c487 rebuild_padding参数变动导致ci报错;
2)775edcc 默认开启cuda graph导致ci报错

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Oct 21, 2025

Thanks for your contribution!

@paddle-bot paddle-bot bot added the contributor External developers label Oct 21, 2025
@wuyujiji wuyujiji force-pushed the fix_ci branch 4 times, most recently from b8ef563 to d37ca2a Compare October 21, 2025 07:48
@wuyujiji wuyujiji changed the title [Iluvatar GPU] fix ci caused by rebuild_padding params [Iluvatar GPU] fix ci error caused by rebuild_padding param and cuda graph Oct 21, 2025
Copy link
Collaborator

@EmmonsCurse EmmonsCurse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongshaotian
Copy link
Collaborator

gongshaotian commented Oct 21, 2025

 if self.device_config is not None and self.device_config.device_type != "cuda":
            self.graph_opt_config.use_cudagraph = False

config 中的这个检查无法拦截 Iluvatar 吗

@gongshaotian
Copy link
Collaborator

Motivation

ci问题修复: 1)https://github.com/PaddlePaddle/FastDeploy/pull/4464/files#diff-d4959610eb1d6eae1c09cf9134b8f7650184b30a359ccd8fe6e192deb5c0c487 rebuild_padding参数变动导致ci报错; 2)775edcc 默认开启cuda graph导致ci报错

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.

    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.

  • Add unit tests. Please write the reason in this PR if no unit tests.

  • Provide accuracy results.

  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

麻烦补充PR描述,无修改项可以填写 Pass,同时建议勾选 CheckList

"Hello, my name is",
]

# 采样参数
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议统一用英文注释

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面我改一下

Copy link
Collaborator

@gongshaotian gongshaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,代码规范问题可以后续PR补充

@EmmonsCurse EmmonsCurse merged commit dc7faca into PaddlePaddle:develop Oct 21, 2025
23 of 28 checks passed
@wuyujiji
Copy link
Contributor Author

 if self.device_config is not None and self.device_config.device_type != "cuda":
            self.graph_opt_config.use_cudagraph = False

config 中的这个检查无法拦截 Iluvatar 吗

@gongshaotian 我在iluvatar_model_runner的构造函数里打印了fd_config.graph_opt_config.use_cudagraph=True,所以人为设置成False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants