-
Notifications
You must be signed in to change notification settings - Fork 682
[Iluvatar GPU] fix ci error caused by rebuild_padding param and cuda graph #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
b8ef563 to
d37ca2a
Compare
EmmonsCurse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
config 中的这个检查无法拦截 Iluvatar 吗 |
麻烦补充PR描述,无修改项可以填写 Pass,同时建议勾选 CheckList |
| "Hello, my name is", | ||
| ] | ||
|
|
||
| # 采样参数 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议统一用英文注释
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后面我改一下
gongshaotian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,代码规范问题可以后续PR补充
@gongshaotian 我在iluvatar_model_runner的构造函数里打印了fd_config.graph_opt_config.use_cudagraph=True,所以人为设置成False |
Motivation
ci问题修复:
1)https://github.com/PaddlePaddle/FastDeploy/pull/4464/files#diff-d4959610eb1d6eae1c09cf9134b8f7650184b30a359ccd8fe6e192deb5c0c487 rebuild_padding参数变动导致ci报错;
2)775edcc 默认开启cuda graph导致ci报错
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.