Fix bugs of splitwise_complete_prefilled_step IPCsignal clear #4309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
K11OntheBoat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
K11OntheBoat
force-pushed
the
AFD_dev
branch
from
531ab20 to
6510cdc
Compare
zhoutianzi666
approved these changes
Sep 29, 2025
Comment on lines
-447
to
-450
| dp_rank_id = ( | ||
| self.local_rank | ||
| + self.parallel_config.local_data_parallel_id * self.parallel_config.tensor_parallel_size | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
这里是林军之前为了适配TP加的逻辑，改了之后他帮忙测过了TP，没问题.
Contributor
There was a problem hiding this comment.
只会影响PD场景，这里执行前会判断是否是P节点，所以不会影响PD以外的场景，PD+TP在1P1D每个节点tp_size=2的情况下是能跑通的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复当前Dev分支 因为splitwise_complete_prefilled_step IPCsignal 清理没有考虑到DP+EP的Bug.