[NewFeature]custom_allreduce support cudagraph recapture #4305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanlehome
reviewed
Sep 28, 2025
| def clear_graph(self): | ||
| """ """ | ||
| # Clear graphs | ||
| custom_ar_clear_ipc_handles() |
Collaborator
There was a problem hiding this comment.
是不是要在开启custom_all_reduce的情况下才调用这个
Collaborator
There was a problem hiding this comment.
是不是要在开启custom_all_reduce的情况下才调用这个
custom_all_reduce 是默认开了
Collaborator
Author
There was a problem hiding this comment.
是不是要在开启custom_all_reduce的情况下才调用这个
custom_ar_clear_ipc_handles()函数内部会判断有CustomAllreduce对象(_TP_AR)才会clear的。
qingqing01
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom_allreduce support cudagraph recapture