Fix the confused enable_early_stop when only set early_stop_config #3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanlehome
approved these changes
Aug 5, 2025
gzy19990617
pushed a commit
to gzy19990617/FastDeploy
that referenced
this pull request
Aug 7, 2025
…addlePaddle#3214) * fix the confused early_stop_config when only set early_stop_config * pre-commit * write a general method
Jiang-Jia-Jun
pushed a commit
that referenced
this pull request
Aug 8, 2025
* fix noaux_tc op * fix * update * fix qk norm * fix linear for prequant loader * test * fix * fix * rm some print * fix noaux_tc op * test * Fix the confused enable_early_stop when only set early_stop_config (#3214) * fix the confused early_stop_config when only set early_stop_config * pre-commit * write a general method * Add ci case for min token and max token (#3229) Co-authored-by: xujing43 <[email protected]> * add some evil cases (#3240) * add repitation early stop cases * add repitation early stop cases * add bad cases * add bad cases * add evil cases * qwen3_moe (#3084) * [Feature] support seed parameter (#3161) * support seed * fix * add SamplingMetadata seed test * The next_tokens values are inconsistent! * add air and rejection seed test * fix * add SamplingParams seed test * fix seed=0 * Default to defualt * fix * fix args_utils * fix review * fix review * fix * fix * add xpu,gcu,iluvatar support seed * fix * 【Fix Bug】 修复 fa3 支持集中式bug (#3235) * fix fa3 集中式bug * 增加qknorm参数 * fix qk norm * fix * update * fix linear for prequant loader * fix * fix * rm some print * fix * fix moe init weight&scale * fix moe init weight&scale --------- Co-authored-by: bukejiyu <[email protected]> Co-authored-by: yuanxiaolan <[email protected]> Co-authored-by: Zero Rains <[email protected]> Co-authored-by: xjkmfa <[email protected]> Co-authored-by: xujing43 <[email protected]> Co-authored-by: Divano <[email protected]> Co-authored-by: bukejiyu <[email protected]> Co-authored-by: lizexu123 <[email protected]> Co-authored-by: yangjianfengo1 <[email protected]> Co-authored-by: qingqing01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcard-71500
修复enable_early_stop在api_server.log中同时显示True和False的迷惑日志。
问题分析：
启动在线服务时，如果只设置了early_stop_config的参数，没有设置enable_early_stop时，api_server.log在启动好服务后会打印启动参数信息（见下图），这时候enable_early_stop会使用默认值False，但是由于设置了early_stop_config，这个config里面的enable_early_config会显示为True，导致无法确认是否启用early_stop功能。
early_stop只要设置了early_stop_config就一定会根据config内的参数决定是否启动early_stop功能，这时候enable_early_stop的值就不重要了。所以本PR在处理启动参数时新增了对early_stop_config和enable_early_stop的对齐，消除迷惑日志。最终日志如下图。
