[Code Simplification] Refactor Post-processing in VL Model Forward Method #2937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个PR分为三步：
114c5eb(#2937) 精简了forward 后 半部分的算子，通过布尔索引移除了if语句，解决了forward后面碎算子的问题，但是由于引入了bool索引（在全文本token，没有图片token的情况下），性能会下降10b36e6(#2937) 精简了forward 前 半部分不必要的算子e545864(#2937) 修复了第一个 commit 中性能下降的问题，将布尔索引移动到后面自定义算子extract_text_token_output_kernel中，原因是Paddle中的布尔索引，使用non_zero+gather_nd组合实现，non_zero存在一个 gpu -> cpu 的过程，这个过程比较耗时，同时，由于移除了布尔索引，性能会略有提升cc @zyfncg @SigureMo