[Bug fix] fix attention rank init #2743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
yuanlehome
reviewed
Jul 8, 2025
Comment on lines
109
to
+116
| if fd_config.parallel_config.expert_parallel_rank is None: | ||
| fd_config.parallel_config.expert_parallel_rank = 0 | ||
| device_id = self.rank + fd_config.parallel_config.tensor_parallel_degree * \ | ||
| fd_config.parallel_config.expert_parallel_rank | ||
| if self.device_id is None: | ||
| self.device_id = device_id | ||
| self.device_id = self.rank | ||
| else: | ||
| self.device_id = self.device_id.split(",")[device_id] | ||
| device_ids = self.device_id.split(",") | ||
| rank_index = self.rank % len(device_ids) | ||
| self.device_id = self.device_id[rank_index] |
Collaborator
There was a problem hiding this comment.
这一块代码以及94行代码要不封装成一个utils函数？不然每一个attention_backend都要复写一遍
yuanlehome
approved these changes
Jul 8, 2025
RichardWooSJTU
added a commit
that referenced
this pull request
Jul 8, 2025
This reverts commit e8bbe72.
EmmonsCurse
pushed a commit
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the attention class, the
self.rankparameter is utilized to initialize the metadata for key-value (KV) signals. However, the original implementation inadvertently caused inconsistencies in the KV signal handling. This pull request resolves the issue by incorporating EP configuration details to ensure proper initialization and alignment of KV signals.