Extract eh_proj Layer from ParallelLMHead for MTP to Avoid Weight Transposition Issue #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
freeliuzc
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MTP and
tie_word_embeddings=true, unexpected weight transposition behavior may occur.The specific reason is that the
eh_projlayer in MTP reuses theParallelLMHeadclass. When MTP is turned on, its internal judgment logic abouttie_word_embeddingswill cause theeh_projweight to produce unexpected transposition behavior. Therefore, theeh_projlayer of MTP is extracted separately to facilitate subsequent development.