Remaining C#-based fixes for 4.1.4 release. #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if a job-type parameter is specified. This is needed for people using ServiceUI via `Start-ADTProcess` to get something niche/specific working.
…warnings/issues.
This necessitated switching back to `dotnet` which we switched from initially for iNKORE. We're still using it in msbuild.exe mode though, and the underlying issue causing `dotnet build` to fail for iNKORE was resolved via "- Remove iNKORE `Resource.Embedder` usage to alleviate reported WDAC warnings/issues." anyway.
…rver.ClientPermissions` class.
DanGough
reviewed
Sep 3, 2025
Contributor
DanGough
left a comment
DanGough
left a comment
There was a problem hiding this comment.
I was not familiar with this syntax (https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-9.0/target-typed-new) in 18e6068.
After further investigation it's only supported by C# 9, and not supported to work in .NET 4.7.2 - however it seems to be working fine during testing.
DanGough
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1679.
Fixes https://discourse.psappdeploytoolkit.com/t/v4-1-3-show-adtinstallationwelcome-closeprocesses-isnt-working/6904
Fixes https://discourse.psappdeploytoolkit.com/t/4-1-3-show-adtballoontip-the-client-process-returned-an-exception-access-denied/6890
Fixes https://discord.com/channels/618712310185197588/627204361545842688/1411960229444456478
Fixes https://discord.com/channels/618712310185197588/627204361545842688/1412088867116417135
Fixes https://www.reddit.com/r/PSADT/comments/1n5o0un/complex_script_for_rtl_languages_in_the_toast/
Fixes #1693
Fixes #1697
https://discourse.psappdeploytoolkit.com/t/4-1-3-show-adtinstallationrestartprompt-task-manager/6899/5?u=mjr4077au
Fixes https://discourse.psappdeploytoolkit.com/t/4-1-3-trying-to-display-a-command-prompt-using-serviceui/6896
Fixes https://discord.com/channels/618712310185197588/627204361545842688/1410985136497098822
Fixes https://discourse.psappdeploytoolkit.com/t/4-1-3-adt-ui-system/6905