@hainest: this looks good to me. One question: while the change looks good as it will improve global symbol management, I am curious by the comment:

This error wasn't detect by gcc versions before 10.0.

What is the error? This conflicts with another global symbol in which case where does it come from?

What is the error? This conflicts with another global symbol in which case where does it come from?

One comes from ninja_test_hypre_parasails.o and the other from ninja_test_util.o. I'm guessing, but it's plausible the reason earlier gcc's didn't detect the error is because they didn't take into account that the arrays are different lengths.

@hainest: make sense. Would that make sense to hide those other symbols into the file scope as well?

Because C doesn't have namespaces, I tend to be conservative and give globals internal linkage. Currently, I don't see any other linker issues, but that doesn't guarantee there aren't any.

Cool. I will accept the patch then.

Thanks!