Handle no sequence id dataset (and decrease Cmake version to 3.22) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @bexcite for pointing out the issue with Thanks for your contibution. |
saurabh1002
added a commit
that referenced
this pull request
Mar 21, 2024
* Cmake version to 3.22 and handle no sequence id * Update cmake version for consistency * Update cmake required version in pyproject.toml --------- Co-authored-by: Saurabh Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Just two nits from my first runs that I stumbled upon.
Decrease CMake version to 3.22.
Motivation: CMake version requirements 3.25 is a bit high for people who use the packaged CMake with Ubuntu 22 (it's 3.22 there as I can tell), i.e. it's always good to make the builds easier unless you really really need the CMake 3.25 capabilities (which I can't tell fully, but CMake 3.22 built the thing nicely on my Ubuntu 22 setup)
Handled the absence of sequence_id, so datasets like Ouster are working too (the same handling as present in Kiss-ICP just moved there.
Thanks for the cool project, and feel free to reject this all if it's not aligning with your vision, I just decided to push what I fixed to make it work for me (btw, I followed build step precisely as they described in README and they are good)