upgrade versions for sophus to avoid old cmake version errors #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tizianoGuadagnino
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build from source is currently failing due to a CMake version support issue, as shown below:
This issue is occurring for **Sophus third-party build because of old version of this libraries with a cmake minimum version of 3.4
This PR bumps the versions of Sophus that we FetchContent through our build systems, which fixes the build error.
Sophus 1.22.10 -> 1.24.6
Additionally, with Sophus version being upgraded,
sophus.patchis no longer needed since they also remove the ugly macros for the fmt library in their newer release :)