Skip to content

Cleanup python API #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tizianoGuadagnino merged 12 commits into from
Jul 25, 2024
Merged

Cleanup python API #25

tizianoGuadagnino merged 12 commits into from
Jul 25, 2024

Conversation

@saurabh1002
Copy link
Collaborator

@saurabh1002 saurabh1002 commented Jul 25, 2024

  1. Use "Stub" classes for all optional stuff, avoid if else checks in pipeline
  2. Filter gt_closures based on overlap threshold directly in the function
  3. Use dataclass decorator for all suitable classes
  4. Save KISS poses in kitti format, easy for evaluations using evo
  5. Handle default config when no config file provided directly in load_config function

tizianoGuadagnino
tizianoGuadagnino approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@tizianoGuadagnino tizianoGuadagnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastico

@tizianoGuadagnino tizianoGuadagnino merged commit 318673b into main Jul 25, 2024
@saurabh1002 saurabh1002 deleted the cleanup_python branch July 25, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tizianoGuadagnino tizianoGuadagnino tizianoGuadagnino approved these changes

Assignees

No one assigned

Labels

python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saurabh1002 @tizianoGuadagnino