Bug: invalid G1 and G2 cached in PrivateKey #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
added a commit
to furszy/bitcoin-core
that referenced
this pull request
Nov 26, 2021
eaf7d2d1a4 Merge PIVX-Project/bls-signatures#11: Bug: invalid G1 and G2 cached in PrivateKey 183be2750c BugFix: Invalidate caches in PrivateKey copy assignment operator 427246653c QA: test cache invalidation for PrivateKey copy assignment operator git-subtree-dir: src/chiabls git-subtree-split: eaf7d2d1a49115c8d098f96f80b5db9aa487b1d5
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Dec 1, 2021
bc84ff0 Doc: add bls-sigs repo to developer-notes subtrees section (furszy) 9daeb29 Squashed 'src/chiabls/' changes from bc64f128f0..eaf7d2d1a4 (furszy) Pull request description: Updating the bls-signatures subtree, reason is PIVX-Project/bls-signatures#11 (which gladly was detected before v6.0). Coming from #2631 investigation. Pulling up to PIVX-Project/bls-signatures@eaf7d2d. ACKs for top commit: random-zebra: utACK bc84ff0 Tree-SHA512: 91744a317eb8834bdac792a2cfc0fca306bb63798ec037743057c87238087c68b2bceca5811d6fdb9865a8a3ba5f5dd7268bebd398bc2d80223cd3e1baa625bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty serious bug in the copy-assignment operator, discovered after a long investigation with @furszy over an intermittent failure in a unit test for deterministic masternodes in Core.
For reference, pull request submitted upstream: Chia-Network#289