[Zerocoin] remove CTransaction::IsZerocoinSpend/IsZerocoinMint #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erocoinMint - uniform IsZerocoinSpend/IsZerocoinMint CScript functions - refactor CTxIn::IsZerocoinSpend / CTxOut::IsZerocoinMint encapsulating CScript methods - add CTransaction methods: HasZerocoinMintOutputs / HasZerocoinSpendInputs - refactor CTransaction::ContainsZerocoins from previous 'HasZerocoin' functions - fix implementation of CTransaction::GetZerocoinMinted (from CTxOut) - remove extra checks for empty scripts (as those are done in CScript functions)
ghost
added
the
random-zebra
changed the title
furszy
reviewed
May 8, 2019
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
code looks good and PoS/zPoS functional test are passing 👍 . Will play a little bit more with this before totally approve it.
Warrows
approved these changes
May 11, 2019
furszy
approved these changes
May 13, 2019
Mrs-X
approved these changes
May 14, 2019
random-zebra
added a commit
that referenced
this pull request
May 14, 2019
…nMint f14569f [Zerocoin] remove CTransaction::IsZerocoinSpend and CTransaction::IsZerocoinMint (random-zebra) Tree-SHA512: 0e7ab5ee37215454af1b09d25454bedaf8f92baf0ca598d5c639bb1b6f642ca93d21a8d2707af3c4cece06d7b6cd98a019e8b4c16712d774f23b5b41ee059a57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes zerocoin mints and/or spends tx identification considering the fact that a transaction can have multiple zerocoin spend inputs and multiple zerocoin mint outputs.