Skip to content

Conversation

@StakeBox
Copy link

Fixes the pubkey as seen in masternode tab

@StakeBox StakeBox merged commit e632c21 into PIVX-Project:master Nov 15, 2016
@Mrs-X Mrs-X deleted the MN_List_Fix branch January 8, 2017 12:17
random-zebra pushed a commit to random-zebra/PIVX that referenced this pull request Feb 14, 2019
[Tests] fix solve_stake nTime / nStakeModifier
random-zebra added a commit that referenced this pull request Mar 18, 2020
…sRow

359f70e [GUI] Explicit cast from quint32 to bool in filterAcceptsRow (random-zebra)

Pull request description:

  This is a (hopefully definitive) fix for a strange segfault I was consistently having on testnet with the GUI wallet (during the loading of the stake charts), with the following stacktrace
  ```
  #0  0x00007ffff58363bb in  ()
      at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
  #1  0x00007ffff583b25d in  ()
      at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
  #2  0x00007ffff583b932 in  ()
      at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
  #3  0x00007ffff583bca9 in  ()
      at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
  #4  0x00007ffff583c50a in QSortFilterProxyModel::invalidateFilter() ()
      at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
  #5  0x00005555556aa809 in DashboardWidget::updateStakeFilter() (this=this@entry=0x5555577817d0) at qt/pivx/dashboardwidget.cpp:480
  #6  0x00005555556ac736 in DashboardWidget::getAmountBy() (this=this@entry=0x5555577817d0) at qt/pivx/dashboardwidget.cpp:503
  #7  0x00005555556ad1a1 in DashboardWidget::loadChartData(bool) (this=this@entry=0x5555577817d0, withMonthNames=false)
      at qt/pivx/dashboardwidget.cpp:556
  #8  0x00005555556ad703 in DashboardWidget::run(int) (this=0x5555577817d0, type=<optimized out>) at qt/pivx/dashboardwidget.cpp:812
  #9  0x00005555557641d4 in Worker::process() (this=0x5555576314c0)
      at qt/pivx/loadingdialog.cpp:12
  #10 0x00007ffff56932b2 in  () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
  #11 0x00007ffff569617d in  () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
  #12 0x00007ffff4ae36db in start_thread (arg=0x7ffe61ffb700) at pthread_create.c:463
  #13 0x00007ffff2c9e88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
  ```

  Explicit the cast to bool when checking the transaction type in `TransactionFilterProxy::filterAcceptsRow`.

ACKs for top commit:
  furszy:
    detective work 👍 , utACK 359f70e.
  Fuzzbawls:
    utACK 359f70e then

Tree-SHA512: f1481a0545fb1ebe62b28232f9257e6c52306ff15dd1dcefc29d4eeb3dd25b7231d48416cad528e720fb68aa192b089e14bfc8ee92e55406ea02fc777f552b15
Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Sep 24, 2020
98261b1e7b Merge PIVX-Project#22: Clamp JSON object depth to PHP limit
54c4015415 Clamp JSON object depth to PHP limit
5a58a46671 Merge PIVX-Project#21: Remove hand-coded UniValue destructor.
b4cdfc4f47 Remove hand-coded UniValue destructor.
7fba60b5ad Merge PIVX-Project#17: [docs] Update readme
4577454e7e Merge PIVX-Project#13: Fix typo
ac7e73cda8 [docs] Update readme
7890db99d6 Merge PIVX-Project#11: Remove deprecated std pair wrappers
40e34852ac Merge PIVX-Project#14: Cleaned up namespace imports to reduce symbol collisions
4a4964729b Fix typo
85052a4819 Remove deprecated std::pair wrappers
51d3ab34ba Merge PIVX-Project#10: Add pushKV(key, boolean) function (replaces PIVX-Project#5)
129bad96d5 [tests] test pushKV for boolean values
b3c44c947f Pushing boolean value to univalue correctly
07947ff2da Merge PIVX-Project#9: [tests] Fix BOOST_CHECK_THROW macro
ec849d9a28 [tests] Fix BOOST_CHECK_THROW macro
d208f986dd Cleaned up namespace imports to reduce symbol collisions
31bc9f5a49 Merge PIVX-Project#8: Remove unused Homebrew workaround
fa042093d1 Remove HomeBrew workaround
a523e08ae4 Merge PIVX-Project#7: Declare single-argument (non-converting) constructors "explicit"
a9e53b38ba Merge PIVX-Project#4: Pull upstream
fe805ea74f Declare single-argument (non-converting) constructors "explicit"
8a2d6f1e36 Merge pull request PIVX-Project#41 from jgarzik/get-obj-map
ba341a20d7 Add getObjMap() helper method.  Also, constify checkObject().
ceb1194137 Handle .pushKV() and .checkObject() edge cases.
107db98299 Add ::push_back(double) method for feature parity.
d415300316 Move one-line implementation of UniValue::read() to header.
52e85b35b8 Move exception-throwing get_* methods into separate implementation module.
16a1f7f6e9 Merge PIVX-Project#3: Pull upstream
daf1285af6 Merge pull request PIVX-Project#2 from jgarzik/master
f32df99e96 Merge branch '2016_04_unicode' into bitcoin
280b191cb1 Merge remote-tracking branch 'jgarzik/master' into bitcoin
2740c4f712 Merge branch '2015_11_escape_plan' into bitcoin

git-subtree-dir: src/univalue
git-subtree-split: 98261b1e7be4ce9820e25c8ce37d40cdef19ab20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants