[Refactor] Refactor bignum header file into several files #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Fuzzbawls
requested changes
Oct 11, 2018
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
Concept ACK
However, some styling changes are needed after doing an initial once-over look.
Warrows
force-pushed
the
zerocoin_bignum_refactor
branch
from
9d4c1d1 to
32dd307
Compare
Author
|
Styling changes done. |
Warrows
force-pushed
the
zerocoin_bignum_refactor
branch
from
32dd307 to
80ea9dd
Compare
|
Concept ACK. |
Collaborator
|
needs rebase |
Warrows
force-pushed
the
zerocoin_bignum_refactor
branch
2 times, most recently
from
0906ebf to
d91ad90
Compare
Warrows
force-pushed
the
zerocoin_bignum_refactor
branch
from
d91ad90 to
4e4975b
Compare
Author
|
Rebased. |
Closed
Fuzzbawls
approved these changes
Apr 29, 2019
|
ACK |
Fuzzbawls
added a commit
that referenced
this pull request
Apr 29, 2019
4e4975b [Refactor] Refactor bignum header file into several files (warrows) Tree-SHA512: 52f0ad549bfd03731ac388ad8f07ae59d960549f49ac1f73c228ce14b1ef227f34408efce6198997754a230f8fae879939cbcfb75ffc16045a774849129242b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #717