[RPC] Segfault pivx-cli getinfo while loading block index #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ACK 336e3d8 |
Collaborator
|
good catch! ACK 336e358 |
presstab
added a commit
that referenced
this pull request
Feb 14, 2018
336e3d8 [RPC] Segfault pivx-cli getinfo while loading block index (Mrs-X) Tree-SHA512: 30bf65f7f527ba78bdcd0e2fef4da77f15a049f605a0cb3000b565c0e19e8dd274a137d1371435c0793617004591757b6b5e31029ed7a247d46bb6368cfec88b
|
ACK |
|
This may be related, but I can also get
Results in |
random-zebra
added a commit
that referenced
this pull request
Oct 11, 2020
1947519 [Cleanup] Remove unneeded "fix" for segfault with getinfo on startup (random-zebra) 84acfa1 [RPC] Throw immediately if RPC is used when the server is in warmup (random-zebra) Pull request description: **Problem**: Most RPC commands crash the wallet during the initialization phase. **Solution**: An attempt to fix this specifically for `getinfo` was made in #543, checking the existence of `chainActive.Tip()`. A better solution, instead of checking all places that try to access the block index, (or the chainstate, or the second layer maps, etc...), is to throw a JSON-RPC exception with any call, if the server is still in warm-up phase (returning the exact init message), directly from `CRPCTable::execute`. Closes #1908 ACKs for top commit: furszy: ACK 1947519 Fuzzbawls: utACK 1947519 Tree-SHA512: 4f37e512cb411473135c6d1fbb5013bddbcfca62b8a1ed6777481e90f60374480e3617ed1329a10d3cb1e614a2f17a827da2dce1da793b0db3c6b13222cdec19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
pivx-cli getinfoduring the initial blockindex-load results in a segmentation fault.There are lots of places where
chainActive.Tip()is not explicitly checked, but I tested them (hopefully) all and only getinfo seems to have problems.