[GUI] Make "For anonymization and staking only" checked by default #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Collaborator
|
hmm...not sure I really like having to uncheck the box when going to send funds. Maybe it's time to include a request mode parameter to the call so it can be determined wither or not the request came from clicking a send button or not? |
Author
Collaborator
|
the more I think about this, the more it makes sense to add request state to the GUI unlock call. While a generic call from the menu could certainly default to having the staking/anon only box ticked...it makes no sense whatsoever to have that ticked when the call originates from a spend pathway, since it would result in a failed spend attempt. |
Mrs-X
force-pushed
the
MrsX_Default_unlock_settings
branch
from
2b2ab8d to
1ee7810
Compare
Author
|
The unlock calls have now a proper context and the checkbox is set correctly. I think I've tested all functions where unlocking is needed, but would appreciate additional tests in case I should have missed one, or if the checkbox is not correct for some of them. |
Warrows
reviewed
Feb 26, 2018
There was a problem hiding this comment.
Code looks good, and I think I tested everything except for masternodes.
A few nits/questions:
-Couldn't the box be checked for bip38?
-Is it useful to always show the checkbox? I feel like in most cases it would be better to hide it since there is no point in letting the user unlock for staking only if he wants to do a send.
-Probably unrelated but I was not able to create a multisig address because the coincontrol was showing empty in this context.
Author
|
@Warrows Both good and valid points, for BIP38 it's now checked by default, and for sending PIV (or zPIV) the box is hidden now. I have no problems with coin control for multisig, so it's most probably not related to this PR. |
|
Sounds good. I'll have a look at it and also try to test multisig and masternodes. |
Mrs-X
force-pushed
the
MrsX_Default_unlock_settings
branch
from
02d456f to
4e5b73e
Compare
Author
I really HATE it that NetBeans does things like this without any notice. It's fixed ( |
Warrows
reviewed
Feb 28, 2018
Warrows
left a comment
Warrows
left a comment
There was a problem hiding this comment.
I just tested multisig and masternode. They are working fine. But in both cases it's possible to check the checkbox (and the operation will actually be achieved seamlessly), which does not make much sense IMO.
By the way, maybe it would make sense to have an option to (or even automatically) relock the wallet after most operations. Idk if it's the scope of this PR.
I agree with this statement. I once left my wallet unlocked for weeks without knowing it, during which, someone could have walked up and sent my funds away without me knowing it. It isn't intuitive that unlocking for sending will leave the wallet unlocked until locked again. |
Author
|
@Rock-N-Troll That's a can of worms, it existed already but was broken. I've created an issue for that so I won't forget it: #553 @Warrows I think I remember that at least the masternode unlocking had issues with relocking in some cases, that's why I left it as it is. I'll merge it as it is now... |
Mrs-X
added a commit
that referenced
this pull request
Mar 2, 2018
…y default 4e5b73e [GUI] Make "For anonymization and staking only" checked by default (Mrs-X) Tree-SHA512: 53d5aa663269efdb82cb2d8961f2eae4aebc03a6d96d15d990b357385584e365935f012eb9410b81de891a1d1ed75fbfe88937b2e87df12db148b1d6e3c015a5
Fuzzbawls
added
the
Needs Release Notes
|
ACK |
Fuzzbawls
removed
the
Needs Release Notes
2a5A1Ghu1
added a commit
to theohmproject/ohmcoin
that referenced
this pull request
Oct 24, 2020
squidicuzz
pushed a commit
to theohmproject/ohmcoin
that referenced
this pull request
Oct 28, 2020
2a5A1Ghu1
added a commit
to theohmproject/ohmcoin
that referenced
this pull request
Oct 28, 2020
* Ohmcoin 3.0 (#63) * Fix croscompile for win32 * Update Segwit and Zerocoin (#47) * Added all of the code for the update * Fix URL Path * Fixed default directory path * Change masternode declarations to karmanode * change to ohmcoin * Create .gitignore * Update .gitignore * Update .gitignore * karmanodefy * Update proposallist.cpp * Missing class * Docs Masternode to karmanode * Change mn(masternode) to kn(karmanode) * Update doc and comment collateral * More doc updates * Fixed Karmanode references in proposal related files. * Ckarmanode -> CKarmanode * Karmanodefy Budget System * Porotocol and Version Bump * Protocol Enforcement * Fix typo * Spork fixes * Fix Spork Typo * Develop (#48) * Added all of the code for the update * Fix URL Path * Fixed default directory path * Change masternode declarations to karmanode * change to ohmcoin * Create .gitignore * Update .gitignore * Update .gitignore * karmanodefy * Update proposallist.cpp * Missing class * Docs Masternode to karmanode * Change mn(masternode) to kn(karmanode) * Update doc and comment collateral * More doc updates * Fixed Karmanode references in proposal related files. * Ckarmanode -> CKarmanode * Karmanodefy Budget System * Porotocol and Version Bump * Protocol Enforcement * Fix typo * Spork fixes * Update README.md * Fixes issues when building in 10.15 This will need to be built against different brew formulas that will be provided on release... This is also a temporary solution once fixes are made for building against updated dependencies. * Qt Frontend Performace Limits amount of txs loaded * Added Qt Dependencies for Cross Compile * Update spork.h * [Qt][Bug] Load the most recent instead of the first transactions PIVX-Project/PIVX@ec72107 * Fix QT and Boost bugs phoreproject/Phore#140 * Update Seeders * Update Budget and Regtest * More Budget and Regtest * Too Expressive removed arrant parenthesis * Added select coin strategy phoreproject/Phore@5928d0b * allow openssl1.0/1.1 to coexist phoreproject/Phore@d1b6037 * Prevent RPC calls during warmup * Changed for loop copies to references, and added stake logging phoreproject/Phore@3e7f6cf * Fixed masternode edit deleting two masternodes in list * Fix staking assertion phoreproject/Phore@0a6a243 * Added Python test for transaction too large issue phoreproject/Phore@5b08df9 * Added benchmark in mutex lock phoreproject/Phore@be2f913 * Fix bugs in mnemonic selection and mint maturity phoreproject/Phore@c118242 * Revert "Fix bugs in mnemonic selection and mint maturity" This reverts commit 2f242b0. * Replaced mapNextTx with smaller map to reduce memory usage. phoreproject/Phore@3a7c813 * Move ThreadStakeMinter out of net.cpp phoreproject/Phore@5568806 * Revert "Changed for loop copies to references, and added stake logging" This reverts commit 113aeea. * Add missing QPainterPath include PIVX-Project/PIVX@2e226ad * Lighter Icons * Update Checkpoints * Switch Sporks * Update Placeholder Address * Ohmify * Merge Block Changes (#56) * Version 3.0.0.1 dev (#53) * Version 3.0.0.1 dev - Increase time between blocks at block 2977924 or when network has reached 95% upgrade threshold - Change block time to 4 minutes - Set block reward to 6 on activation of new time - Adjust new block enforce policy to 24 hour span * fix flag check for; add fIgnoreLegacyBlocks * move variable out of if statement, fix compile. * Improve2 (#54) * WIP: upgrade network upgrade features; testnet fixes.. * add this back for now.. * add missed file, optional.h * more imports * adjust imports for consensus.h * correction * fix moar missing imports * add missing vars and fixes * missing header declare * changes.. * update makefile * need this here too.. * fixed compile * further fixed. * Zerocoin is not active; Actually use new block version parameter.. * Don't do this, zerocoin not active.. * remove or fix zerocoin at some later point. * zerocoin is off. * Adjust new block version update to use protocol version Prepare for removal of zercoin; refactoring.. Implement sporks to enforce new version lock ins. * fix compile issues * get height for tip * get consensus params * add missing spork info * Version 3.0.2.0 * Fixes Wallet Lock Issue (#55) * Fix block height condition * Combine Spork 24 into 23 Co-authored-by: Ra's Al Ghul <[email protected]> Co-authored-by: squidicuz <[email protected]> * [REST] improve performance for JSON calls bitcoin/bitcoin@30973e9 JSON calls do not use the raw data generated for the .bin and .hex calls. By moving the raw data creation into the .bin and .hex switch branches, JSON calls become faster. * Bump Version * [Model][Performance] Unnecessary double cs_wallet and cs_main lock. PIVX-Project/PIVX@9d94ea6 * Delete pkg.m4 Delete arrant pkg.m4 file never was needed * Update Mac version * Drop QT4 Support * [BUILD][MacOS] Make Clean Images * [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir * [Refactor][Move Only] Wallet Move to Sub-Dir * Add Memusage * [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH * [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for * [LEVELDB]Use std::atomic instead of MemoryBarrier * Update Copyright * [Tests] Fix chain ordering in budget tests PIVX-Project/PIVX#595 * [Doc] Change aarch assert sign output folder PIVX-Project/PIVX#585 * [Wallet] Adjust staking properties to lower orphan rates. PIVX-Project/PIVX#617 * [Wallet] Write new transactions to wtxOrdered properly PIVX-Project/PIVX#597 * [Travis] Add separate job to check doc/logprint/subtree Further getting up to date with pivx PIVX-Project/PIVX#639 * [Build] Make sure Boost headers are included for libzerocoin PIVX-Project/PIVX#622 * [Build] Remove unnecessary BOOST dependency PIVX-Project/PIVX#605 * [Bug] Fix CKarmanodeConfig::read rebase from upstream. Windows doesn't initialize CService properly during startup before the masternode.conf file is read. PIVX-Project/PIVX@9837f53 * Add getaccumulatorvalues RPC Return the accumulator values associated with a particular block height. PIVX-Project/PIVX@8a6d425 * [GUI] Fix wrongly displayed balance on Overview tab PIVX-Project/PIVX#598 * [Wallet] Fix double locked coin when wallet and MN are on same machine PIVX-Project/PIVX#656 * [Qt] Add Tor service icon to status bar Tor Icon is displayed when the client is initialized with a successful tor service connection. Icon is hidden otherwise. PIVX-Project/PIVX@f9e18aa * [Staking] Prevent potential negative out values during stake splitting PIVX-Project/PIVX#952 * [QT] Set AA_EnableHighDpiScaling attribute early Set AA_EnableHighDpiScaling attribute early bitcoin/bitcoin@099e4b9 * [BUILD] Update bitcoin_qt.m4 * [QT] clean up initialize/shutdown signals qt: clean up initialize/shutdown signals - Change initializeResult(int) to initializeResult(bool) to avoid implicit type conversion. - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers. - Remove the argument from shutdownResult(int); it was called with a constant argument. bitcoin/bitcoin#9834 * [Refactor] Set to nullptr after delete bitcoin/bitcoin#10027 * [Main] Unify shutdown proceedure in init rather than per-app and [Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored. PIVX-Project/PIVX#1029 PIVX-Project/PIVX#769 * [GUI] Make "For anonymization and staking only" checked by default PIVX-Project/PIVX#521 * [Trivial] Remove CMasternode::SliceHash PIVX-Project/PIVX#1513 * [REST] improve performance for JSON calls bitcoin/bitcoin@30973e9 JSON calls do not use the raw data generated for the .bin and .hex calls. By moving the raw data creation into the .bin and .hex switch branches, JSON calls become faster. * Bump Version * [Model][Performance] Unnecessary double cs_wallet and cs_main lock. PIVX-Project/PIVX@9d94ea6 * Delete pkg.m4 Delete arrant pkg.m4 file never was needed * Update Mac version * Drop QT4 Support * [BUILD][MacOS] Make Clean Images * [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir * [Refactor][Move Only] Wallet Move to Sub-Dir * Add Memusage * [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH * [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for * [LEVELDB]Use std::atomic instead of MemoryBarrier * Update Copyright * [Tests] Fix chain ordering in budget tests PIVX-Project/PIVX#595 * [Doc] Change aarch assert sign output folder PIVX-Project/PIVX#585 * [Wallet] Adjust staking properties to lower orphan rates. PIVX-Project/PIVX#617 * [Wallet] Write new transactions to wtxOrdered properly PIVX-Project/PIVX#597 * [Travis] Add separate job to check doc/logprint/subtree Further getting up to date with pivx PIVX-Project/PIVX#639 * [Build] Make sure Boost headers are included for libzerocoin PIVX-Project/PIVX#622 * [Build] Remove unnecessary BOOST dependency PIVX-Project/PIVX#605 * [Bug] Fix CKarmanodeConfig::read rebase from upstream. Windows doesn't initialize CService properly during startup before the masternode.conf file is read. PIVX-Project/PIVX@9837f53 * Add getaccumulatorvalues RPC Return the accumulator values associated with a particular block height. PIVX-Project/PIVX@8a6d425 * [GUI] Fix wrongly displayed balance on Overview tab PIVX-Project/PIVX#598 * [Wallet] Fix double locked coin when wallet and MN are on same machine PIVX-Project/PIVX#656 * [Qt] Add Tor service icon to status bar Tor Icon is displayed when the client is initialized with a successful tor service connection. Icon is hidden otherwise. PIVX-Project/PIVX@f9e18aa * [Staking] Prevent potential negative out values during stake splitting PIVX-Project/PIVX#952 * [QT] Set AA_EnableHighDpiScaling attribute early Set AA_EnableHighDpiScaling attribute early bitcoin/bitcoin@099e4b9 * [BUILD] Update bitcoin_qt.m4 * [QT] clean up initialize/shutdown signals qt: clean up initialize/shutdown signals - Change initializeResult(int) to initializeResult(bool) to avoid implicit type conversion. - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers. - Remove the argument from shutdownResult(int); it was called with a constant argument. bitcoin/bitcoin#9834 * [Refactor] Set to nullptr after delete bitcoin/bitcoin#10027 * [Main] Unify shutdown proceedure in init rather than per-app and [Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored. PIVX-Project/PIVX#1029 PIVX-Project/PIVX#769 * [GUI] Make "For anonymization and staking only" checked by default PIVX-Project/PIVX#521 * [Trivial] Remove CMasternode::SliceHash PIVX-Project/PIVX#1513 Co-authored-by: Crypto Pliskin <[email protected]> Co-authored-by: Ra's Al Ghul <[email protected]>
2a5A1Ghu1
added a commit
to theohmproject/ohmcoin
that referenced
this pull request
Oct 28, 2020
* Fix croscompile for win32 * Update Segwit and Zerocoin (#47) * Added all of the code for the update * Fix URL Path * Fixed default directory path * Change masternode declarations to karmanode * change to ohmcoin * Create .gitignore * Update .gitignore * Update .gitignore * karmanodefy * Update proposallist.cpp * Missing class * Docs Masternode to karmanode * Change mn(masternode) to kn(karmanode) * Update doc and comment collateral * More doc updates * Fixed Karmanode references in proposal related files. * Ckarmanode -> CKarmanode * Karmanodefy Budget System * Porotocol and Version Bump * Protocol Enforcement * Fix typo * Spork fixes * Fix Spork Typo * Develop (#48) * Added all of the code for the update * Fix URL Path * Fixed default directory path * Change masternode declarations to karmanode * change to ohmcoin * Create .gitignore * Update .gitignore * Update .gitignore * karmanodefy * Update proposallist.cpp * Missing class * Docs Masternode to karmanode * Change mn(masternode) to kn(karmanode) * Update doc and comment collateral * More doc updates * Fixed Karmanode references in proposal related files. * Ckarmanode -> CKarmanode * Karmanodefy Budget System * Porotocol and Version Bump * Protocol Enforcement * Fix typo * Spork fixes * Update README.md * Fixes issues when building in 10.15 This will need to be built against different brew formulas that will be provided on release... This is also a temporary solution once fixes are made for building against updated dependencies. * Qt Frontend Performace Limits amount of txs loaded * Added Qt Dependencies for Cross Compile * Update spork.h * [Qt][Bug] Load the most recent instead of the first transactions PIVX-Project/PIVX@ec72107 * Fix QT and Boost bugs phoreproject/Phore#140 * Update Seeders * Update Budget and Regtest * More Budget and Regtest * Too Expressive removed arrant paranthesis * Added select coin strategy phoreproject/Phore@5928d0b * allow openssl1.0/1.1 to coexist phoreproject/Phore@d1b6037 * Prevent RPC calls during warmup * Changed for loop copies to references, and added stake logging phoreproject/Phore@3e7f6cf * Fixed masternode edit deleting two masternodes in list * Fix staking assertion phoreproject/Phore@0a6a243 * Added Python test for transaction too large issue phoreproject/Phore@5b08df9 * Added benchmark in mutex lock phoreproject/Phore@be2f913 * Fix bugs in mnemonic selection and mint maturity phoreproject/Phore@c118242 * Revert "Fix bugs in mnemonic selection and mint maturity" This reverts commit 2f242b0. * Replaced mapNextTx with smaller map to reduce memory usage. phoreproject/Phore@3a7c813 * Move ThreadStakeMinter out of net.cpp phoreproject/Phore@5568806 * Revert "Changed for loop copies to references, and added stake logging" This reverts commit 113aeea. * Add missing QPainterPath include PIVX-Project/PIVX@2e226ad * Lighter Icons * Update Checkpoints * Switch Sporks * Update Placeholder Address * Ohmify * Merge Block Changes (#56) * Version 3.0.0.1 dev (#53) * Version 3.0.0.1 dev - Increase time between blocks at block 2977924 or when network has reached 95% upgrade threshold - Change block time to 4 minutes - Set block reward to 6 on activation of new time - Adjust new block enforce policy to 24 hour span * fix flag check for; add fIgnoreLegacyBlocks * move variable out of if statement, fix compile. * Improve2 (#54) * WIP: upgrade network upgrade features; testnet fixes.. * add this back for now.. * add missed file, optional.h * more imports * adjust imports for consensus.h * correction * fix moar missing imports * add missing vars and fixes * missing header declare * changes.. * update makefile * need this here too.. * fixed compile * further fixed. Co-authored-by: Jon <[email protected]> * Zerocoin is not active; Actually use new block version parameter.. * Don't do this, zerocoin not active.. * remove or fix zerocoin at some later point. * zerocoin is off. * Adjust new block version update to use protocol version Prepare for removal of zercoin; refactoring.. Implement sporks to enforce new version lock ins. * fix compile issues * get height for tip * get consensus params * add missing spork info * Version 3.0.2.0 Co-authored-by: Crypto Pliskin <[email protected]> * Fixes Wallet Lock Issue (#55) * Fix block height condition * Combine Spork 24 into 23 Co-authored-by: squidicuz <[email protected]> * [REST] improve performance for JSON calls bitcoin/bitcoin@30973e9 JSON calls do not use the raw data generated for the .bin and .hex calls. By moving the raw data creation into the .bin and .hex switch branches, JSON calls become faster. * Bump Version * [Model][Performance] Unnecessary double cs_wallet and cs_main lock. PIVX-Project/PIVX@9d94ea6 * Delete pkg.m4 Delete arrant pkg.m4 file never was needed * Update Mac version * Drop QT4 Support * [BUILD][MacOS] Make Clean Images * [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir * [Refactor][Move Only] Wallet Move to Sub-Dir * Add Memusage * [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH * [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for * [LEVELDB]Use std::atomic instead of MemoryBarrier * Update Copyright * [Tests] Fix chain ordering in budget tests PIVX-Project/PIVX#595 * [Doc] Change aarch assert sign output folder PIVX-Project/PIVX#585 * [Wallet] Adjust staking properties to lower orphan rates. PIVX-Project/PIVX#617 * [Wallet] Write new transactions to wtxOrdered properly PIVX-Project/PIVX#597 * [Travis] Add separate job to check doc/logprint/subtree Further getting up to date with pivx PIVX-Project/PIVX#639 * [Build] Make sure Boost headers are included for libzerocoin PIVX-Project/PIVX#622 * [Build] Remove unnecessary BOOST dependency PIVX-Project/PIVX#605 * [Bug] Fix CKarmanodeConfig::read rebase from upstream. Windows doesn't initialize CService properly during startup before the masternode.conf file is read. PIVX-Project/PIVX@9837f53 * Add getaccumulatorvalues RPC Return the accumulator values associated with a particular block height. PIVX-Project/PIVX@8a6d425 * [GUI] Fix wrongly displayed balance on Overview tab PIVX-Project/PIVX#598 * [Wallet] Fix double locked coin when wallet and MN are on same machine PIVX-Project/PIVX#656 * [Qt] Add Tor service icon to status bar Tor Icon is displayed when the client is initialized with a successful tor service connection. Icon is hidden otherwise. PIVX-Project/PIVX@f9e18aa * [Staking] Prevent potential negative out values during stake splitting PIVX-Project/PIVX#952 * [QT] Set AA_EnableHighDpiScaling attribute early Set AA_EnableHighDpiScaling attribute early bitcoin/bitcoin@099e4b9 * [BUILD] Update bitcoin_qt.m4 * [QT] clean up initialize/shutdown signals qt: clean up initialize/shutdown signals - Change initializeResult(int) to initializeResult(bool) to avoid implicit type conversion. - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers. - Remove the argument from shutdownResult(int); it was called with a constant argument. bitcoin/bitcoin#9834 * [Refactor] Set to nullptr after delete bitcoin/bitcoin#10027 * [Main] Unify shutdown proceedure in init rather than per-app and [Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored. PIVX-Project/PIVX#1029 PIVX-Project/PIVX#769 * [GUI] Make "For anonymization and staking only" checked by default PIVX-Project/PIVX#521 * [Trivial] Remove CMasternode::SliceHash PIVX-Project/PIVX#1513 * [REST] improve performance for JSON calls bitcoin/bitcoin@30973e9 JSON calls do not use the raw data generated for the .bin and .hex calls. By moving the raw data creation into the .bin and .hex switch branches, JSON calls become faster. * Bump Version * [Model][Performance] Unnecessary double cs_wallet and cs_main lock. PIVX-Project/PIVX@9d94ea6 * Delete pkg.m4 Delete arrant pkg.m4 file never was needed * Update Mac version * Drop QT4 Support * [BUILD][MacOS] Make Clean Images * [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir * [Refactor][Move Only] Wallet Move to Sub-Dir * Add Memusage * [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH * [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for * [LEVELDB]Use std::atomic instead of MemoryBarrier * Update Copyright * [Tests] Fix chain ordering in budget tests PIVX-Project/PIVX#595 * [Doc] Change aarch assert sign output folder PIVX-Project/PIVX#585 * [Wallet] Adjust staking properties to lower orphan rates. PIVX-Project/PIVX#617 * [Wallet] Write new transactions to wtxOrdered properly PIVX-Project/PIVX#597 * [Travis] Add separate job to check doc/logprint/subtree Further getting up to date with pivx PIVX-Project/PIVX#639 * [Build] Make sure Boost headers are included for libzerocoin PIVX-Project/PIVX#622 * [Build] Remove unnecessary BOOST dependency PIVX-Project/PIVX#605 * [Bug] Fix CKarmanodeConfig::read rebase from upstream. Windows doesn't initialize CService properly during startup before the masternode.conf file is read. PIVX-Project/PIVX@9837f53 * Add getaccumulatorvalues RPC Return the accumulator values associated with a particular block height. PIVX-Project/PIVX@8a6d425 * [GUI] Fix wrongly displayed balance on Overview tab PIVX-Project/PIVX#598 * [Wallet] Fix double locked coin when wallet and MN are on same machine PIVX-Project/PIVX#656 * [Qt] Add Tor service icon to status bar Tor Icon is displayed when the client is initialized with a successful tor service connection. Icon is hidden otherwise. PIVX-Project/PIVX@f9e18aa * [Staking] Prevent potential negative out values during stake splitting PIVX-Project/PIVX#952 * [QT] Set AA_EnableHighDpiScaling attribute early Set AA_EnableHighDpiScaling attribute early bitcoin/bitcoin@099e4b9 * [BUILD] Update bitcoin_qt.m4 * [QT] clean up initialize/shutdown signals qt: clean up initialize/shutdown signals - Change initializeResult(int) to initializeResult(bool) to avoid implicit type conversion. - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers. - Remove the argument from shutdownResult(int); it was called with a constant argument. bitcoin/bitcoin#9834 * [Refactor] Set to nullptr after delete bitcoin/bitcoin#10027 * [Main] Unify shutdown proceedure in init rather than per-app and [Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored. PIVX-Project/PIVX#1029 PIVX-Project/PIVX#769 * [GUI] Make "For anonymization and staking only" checked by default PIVX-Project/PIVX#521 * [Trivial] Remove CMasternode::SliceHash PIVX-Project/PIVX#1513 Co-authored-by: Ra's Al Ghul <[email protected]> Co-authored-by: Andrew LaChasse <[email protected]> Co-authored-by: squidicuz <[email protected]>
2a5A1Ghu1
added a commit
to theohmproject/ohmcoin
that referenced
this pull request
Nov 2, 2020
* Ohmcoin performance Updates (#70) * Fix croscompile for win32 * Update Segwit and Zerocoin (#47) * Added all of the code for the update * Fix URL Path * Fixed default directory path * Change masternode declarations to karmanode * change to ohmcoin * Create .gitignore * Update .gitignore * Update .gitignore * karmanodefy * Update proposallist.cpp * Missing class * Docs Masternode to karmanode * Change mn(masternode) to kn(karmanode) * Update doc and comment collateral * More doc updates * Fixed Karmanode references in proposal related files. * Ckarmanode -> CKarmanode * Karmanodefy Budget System * Porotocol and Version Bump * Protocol Enforcement * Fix typo * Spork fixes * Fix Spork Typo * Develop (#48) * Added all of the code for the update * Fix URL Path * Fixed default directory path * Change masternode declarations to karmanode * change to ohmcoin * Create .gitignore * Update .gitignore * Update .gitignore * karmanodefy * Update proposallist.cpp * Missing class * Docs Masternode to karmanode * Change mn(masternode) to kn(karmanode) * Update doc and comment collateral * More doc updates * Fixed Karmanode references in proposal related files. * Ckarmanode -> CKarmanode * Karmanodefy Budget System * Porotocol and Version Bump * Protocol Enforcement * Fix typo * Spork fixes * Update README.md * Fixes issues when building in 10.15 This will need to be built against different brew formulas that will be provided on release... This is also a temporary solution once fixes are made for building against updated dependencies. * Qt Frontend Performace Limits amount of txs loaded * Added Qt Dependencies for Cross Compile * Update spork.h * [Qt][Bug] Load the most recent instead of the first transactions PIVX-Project/PIVX@ec72107 * Fix QT and Boost bugs phoreproject/Phore#140 * Update Seeders * Update Budget and Regtest * More Budget and Regtest * Too Expressive removed arrant paranthesis * Added select coin strategy phoreproject/Phore@5928d0b * allow openssl1.0/1.1 to coexist phoreproject/Phore@d1b6037 * Prevent RPC calls during warmup * Changed for loop copies to references, and added stake logging phoreproject/Phore@3e7f6cf * Fixed masternode edit deleting two masternodes in list * Fix staking assertion phoreproject/Phore@0a6a243 * Added Python test for transaction too large issue phoreproject/Phore@5b08df9 * Added benchmark in mutex lock phoreproject/Phore@be2f913 * Fix bugs in mnemonic selection and mint maturity phoreproject/Phore@c118242 * Revert "Fix bugs in mnemonic selection and mint maturity" This reverts commit 2f242b0. * Replaced mapNextTx with smaller map to reduce memory usage. phoreproject/Phore@3a7c813 * Move ThreadStakeMinter out of net.cpp phoreproject/Phore@5568806 * Revert "Changed for loop copies to references, and added stake logging" This reverts commit 113aeea. * Add missing QPainterPath include PIVX-Project/PIVX@2e226ad * Lighter Icons * Update Checkpoints * Switch Sporks * Update Placeholder Address * Ohmify * Merge Block Changes (#56) * Version 3.0.0.1 dev (#53) * Version 3.0.0.1 dev - Increase time between blocks at block 2977924 or when network has reached 95% upgrade threshold - Change block time to 4 minutes - Set block reward to 6 on activation of new time - Adjust new block enforce policy to 24 hour span * fix flag check for; add fIgnoreLegacyBlocks * move variable out of if statement, fix compile. * Improve2 (#54) * WIP: upgrade network upgrade features; testnet fixes.. * add this back for now.. * add missed file, optional.h * more imports * adjust imports for consensus.h * correction * fix moar missing imports * add missing vars and fixes * missing header declare * changes.. * update makefile * need this here too.. * fixed compile * further fixed. Co-authored-by: Jon <[email protected]> * Zerocoin is not active; Actually use new block version parameter.. * Don't do this, zerocoin not active.. * remove or fix zerocoin at some later point. * zerocoin is off. * Adjust new block version update to use protocol version Prepare for removal of zercoin; refactoring.. Implement sporks to enforce new version lock ins. * fix compile issues * get height for tip * get consensus params * add missing spork info * Version 3.0.2.0 Co-authored-by: Crypto Pliskin <[email protected]> * Fixes Wallet Lock Issue (#55) * Fix block height condition * Combine Spork 24 into 23 Co-authored-by: squidicuz <[email protected]> * [REST] improve performance for JSON calls bitcoin/bitcoin@30973e9 JSON calls do not use the raw data generated for the .bin and .hex calls. By moving the raw data creation into the .bin and .hex switch branches, JSON calls become faster. * Bump Version * [Model][Performance] Unnecessary double cs_wallet and cs_main lock. PIVX-Project/PIVX@9d94ea6 * Delete pkg.m4 Delete arrant pkg.m4 file never was needed * Update Mac version * Drop QT4 Support * [BUILD][MacOS] Make Clean Images * [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir * [Refactor][Move Only] Wallet Move to Sub-Dir * Add Memusage * [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH * [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for * [LEVELDB]Use std::atomic instead of MemoryBarrier * Update Copyright * [Tests] Fix chain ordering in budget tests PIVX-Project/PIVX#595 * [Doc] Change aarch assert sign output folder PIVX-Project/PIVX#585 * [Wallet] Adjust staking properties to lower orphan rates. PIVX-Project/PIVX#617 * [Wallet] Write new transactions to wtxOrdered properly PIVX-Project/PIVX#597 * [Travis] Add separate job to check doc/logprint/subtree Further getting up to date with pivx PIVX-Project/PIVX#639 * [Build] Make sure Boost headers are included for libzerocoin PIVX-Project/PIVX#622 * [Build] Remove unnecessary BOOST dependency PIVX-Project/PIVX#605 * [Bug] Fix CKarmanodeConfig::read rebase from upstream. Windows doesn't initialize CService properly during startup before the masternode.conf file is read. PIVX-Project/PIVX@9837f53 * Add getaccumulatorvalues RPC Return the accumulator values associated with a particular block height. PIVX-Project/PIVX@8a6d425 * [GUI] Fix wrongly displayed balance on Overview tab PIVX-Project/PIVX#598 * [Wallet] Fix double locked coin when wallet and MN are on same machine PIVX-Project/PIVX#656 * [Qt] Add Tor service icon to status bar Tor Icon is displayed when the client is initialized with a successful tor service connection. Icon is hidden otherwise. PIVX-Project/PIVX@f9e18aa * [Staking] Prevent potential negative out values during stake splitting PIVX-Project/PIVX#952 * [QT] Set AA_EnableHighDpiScaling attribute early Set AA_EnableHighDpiScaling attribute early bitcoin/bitcoin@099e4b9 * [BUILD] Update bitcoin_qt.m4 * [QT] clean up initialize/shutdown signals qt: clean up initialize/shutdown signals - Change initializeResult(int) to initializeResult(bool) to avoid implicit type conversion. - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers. - Remove the argument from shutdownResult(int); it was called with a constant argument. bitcoin/bitcoin#9834 * [Refactor] Set to nullptr after delete bitcoin/bitcoin#10027 * [Main] Unify shutdown proceedure in init rather than per-app and [Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored. PIVX-Project/PIVX#1029 PIVX-Project/PIVX#769 * [GUI] Make "For anonymization and staking only" checked by default PIVX-Project/PIVX#521 * [Trivial] Remove CMasternode::SliceHash PIVX-Project/PIVX#1513 * [REST] improve performance for JSON calls bitcoin/bitcoin@30973e9 JSON calls do not use the raw data generated for the .bin and .hex calls. By moving the raw data creation into the .bin and .hex switch branches, JSON calls become faster. * Bump Version * [Model][Performance] Unnecessary double cs_wallet and cs_main lock. PIVX-Project/PIVX@9d94ea6 * Delete pkg.m4 Delete arrant pkg.m4 file never was needed * Update Mac version * Drop QT4 Support * [BUILD][MacOS] Make Clean Images * [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir * [Refactor][Move Only] Wallet Move to Sub-Dir * Add Memusage * [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH * [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for * [LEVELDB]Use std::atomic instead of MemoryBarrier * Update Copyright * [Tests] Fix chain ordering in budget tests PIVX-Project/PIVX#595 * [Doc] Change aarch assert sign output folder PIVX-Project/PIVX#585 * [Wallet] Adjust staking properties to lower orphan rates. PIVX-Project/PIVX#617 * [Wallet] Write new transactions to wtxOrdered properly PIVX-Project/PIVX#597 * [Travis] Add separate job to check doc/logprint/subtree Further getting up to date with pivx PIVX-Project/PIVX#639 * [Build] Make sure Boost headers are included for libzerocoin PIVX-Project/PIVX#622 * [Build] Remove unnecessary BOOST dependency PIVX-Project/PIVX#605 * [Bug] Fix CKarmanodeConfig::read rebase from upstream. Windows doesn't initialize CService properly during startup before the masternode.conf file is read. PIVX-Project/PIVX@9837f53 * Add getaccumulatorvalues RPC Return the accumulator values associated with a particular block height. PIVX-Project/PIVX@8a6d425 * [GUI] Fix wrongly displayed balance on Overview tab PIVX-Project/PIVX#598 * [Wallet] Fix double locked coin when wallet and MN are on same machine PIVX-Project/PIVX#656 * [Qt] Add Tor service icon to status bar Tor Icon is displayed when the client is initialized with a successful tor service connection. Icon is hidden otherwise. PIVX-Project/PIVX@f9e18aa * [Staking] Prevent potential negative out values during stake splitting PIVX-Project/PIVX#952 * [QT] Set AA_EnableHighDpiScaling attribute early Set AA_EnableHighDpiScaling attribute early bitcoin/bitcoin@099e4b9 * [BUILD] Update bitcoin_qt.m4 * [QT] clean up initialize/shutdown signals qt: clean up initialize/shutdown signals - Change initializeResult(int) to initializeResult(bool) to avoid implicit type conversion. - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers. - Remove the argument from shutdownResult(int); it was called with a constant argument. bitcoin/bitcoin#9834 * [Refactor] Set to nullptr after delete bitcoin/bitcoin#10027 * [Main] Unify shutdown proceedure in init rather than per-app and [Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored. PIVX-Project/PIVX#1029 PIVX-Project/PIVX#769 * [GUI] Make "For anonymization and staking only" checked by default PIVX-Project/PIVX#521 * [Trivial] Remove CMasternode::SliceHash PIVX-Project/PIVX#1513 Co-authored-by: Ra's Al Ghul <[email protected]> Co-authored-by: Andrew LaChasse <[email protected]> Co-authored-by: squidicuz <[email protected]> * Add checkpoints; Add Activation Blockhash for Version 3.0.2 Co-authored-by: Ra's Al Ghul <[email protected]> Co-authored-by: squidicuz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #515, the "For anonymization, automint and staking only" checkbox is now checked by default.
Downside is that it's also checked when you try to send coins and the wallet is still locked, so you have to uncheck it before you enter the passphrase.
Since the passphrase-dialog does not have a context from where it's called this can't be easily changed.
It's up to you guys to discuss if we can live with that.