[Wallet] Remove potential memory leak, update multisend code #477
Conversation
ghost
assigned
src/wallet.cpp
Outdated
| if (IsInitialBlockDownload() || IsLocked()) { | ||
| // Stop the old blocks from sending multisends | ||
| if (chainActive.Tip()->nTime < (GetAdjustedTime() - 300) || IsLocked()) { | ||
| LogPrintf("Multisend: disabled on tx's that are being read on initial block loading, %d", chainActive.Tip()->nTime); |
There was a problem hiding this comment.
This could get pretty spammy if resyncing the chain while having multisend activated. I think we should either remove this print statement or change it to something like LogPrint('debug', "Multisend: .....
There was a problem hiding this comment.
I agree. I am not sure this there is merit to print it with the debug flag. I was using this to verify that multi-send still worked. I think removing it completely is the best option.
|
utACK now with a great description ;) |
blondfrogs
changed the title
|
Nicely spotted the potentially missing utACK (will test later...) |
Mrs-X
left a comment
Mrs-X
left a comment
There was a problem hiding this comment.
ACK, works as designed.
When multisend for masternode rewards is enabled it needs a while until the first reward is send (about 15 minutes here), but after that it works for each incoming reward (as long as the wallet/daemon is running).
…d code eae2850 Remove potentional memory leak, update multisend code (blondfrogs) Tree-SHA512: 67930f4f9d18536ef2e473687563a31a1484c7089e548a80c0b30448251394bacdd5d10f122ca7fa718b8cda806ad150d2f9574728cfeed3368852cbd4b70648
Fuzzbawls
changed the title
Investigate a potential bug with multisend not working with Master Node rewards.
The conclusion was that in order for multisend to work the following must be true:
Also, found a potential memory leak and updated the multisend code to fix the memory leak issue.