[Core][GUI][RPC] Exchange Address #2895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liquid369
force-pushed
the
2024_exchange_addr
branch
from
fb54ec7 to
5dafc1d
Compare
panleone
requested changes
Jan 13, 2024
panleone
left a comment
panleone
left a comment
There was a problem hiding this comment.
this is not a complete review: just some things I noticed by scrolling through the code + some questions.
Define in wallet and rpc Adjust destination wrapper typo Add conversion operator Update DecodeDestination
Updates Prefixes from E to EXM, EXT, EXR respectively
Liquid369
force-pushed
the
2024_exchange_addr
branch
3 times, most recently
from
6d6713c to
a17b82e
Compare
Fix review changes minus tests Remove other struct Missed fixes Fix redefinition Remove struct Adjust decode length
Liquid369
force-pushed
the
2024_exchange_addr
branch
3 times, most recently
from
cfee5a1 to
49a1e69
Compare
lint Lint Lint
Liquid369
force-pushed
the
2024_exchange_addr
branch
from
49a1e69 to
c74d76e
Compare
Duddino
requested changes
Feb 8, 2024
Member
Duddino
left a comment
Duddino
left a comment
There was a problem hiding this comment.
Two very minor style nitpicks
Duddino
approved these changes
Feb 9, 2024
Member
There was a problem hiding this comment.
tACK 3743ce176e1cb2fe9c54d4108d97db86b0d1dedd
Maybe we could have a nicer error message when trying to send shield to an exchange address (currently it's Failed to accept tx in the memory pool (reason: bad-txns-invalid-sapling)), but I'm happy to merge as is.
Adjust wallet model
Liquid369
force-pushed
the
2024_exchange_addr
branch
from
0d02bd8 to
19a17dd
Compare
Member
Author
|
Fixed |
Duddino
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement a new OP_CODE and new address type defined as
OP_EXCHANGEADDRandEXCHANGE_ADDRESSrespectively.With the new year and new regulations upcoming, we have been requested to make things easier on the exchanges by introducing this new address type that will not allow private transactions to be input to this address nor coinstake/coinbase transactions.
Consensus checks implemented, we have some variance from the FIRO implementation you can reference https://github.com/firoorg/firo/pull/1356/files for the address encoding and decoding.
OP_CODE introduced is essentially a NOP at the start of the scriptpubkey
New introduced Prefixes are
EXfor Exchange MainnetEXTfor Exchange TestnetEXTfor Exchange RegtestOriginally I went for just an E prefix, but for clarity I followed FIRO for having some difference, if we want to go another direction, I am not particular either way anymore.
New RPC command
getnewexchangeaddressaccepts a label to insert into ContactsWe are not using existing keys to create the pair but generating new.