Skip to content

Conversation

@panleone
Copy link

@panleone panleone commented Sep 6, 2023

The librustzcash update (PR #2870) made shield txs slightly increase in size, this led the functional test feature_blockindexstats.py to fail when the (random) generated fee is too low. With this PR I simply increase the minimum generated fee in order to avoid the issue.

@panleone panleone self-assigned this Sep 6, 2023
@panleone panleone added Trivial extremely simple issues NoFunctionalChanges labels Sep 6, 2023
@panleone panleone added this to the 6.0.0 milestone Sep 6, 2023
Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7203d91

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7203d91

@Fuzzbawls Fuzzbawls merged commit 6829cfd into PIVX-Project:master Sep 13, 2023
@Fuzzbawls Fuzzbawls modified the milestones: 6.0.0, 5.6.0 Feb 6, 2024
@Fuzzbawls Fuzzbawls changed the title [TEST] Fix random fee generation [Tests] Fix random fee generation Feb 9, 2024
@panleone panleone deleted the fix_fees branch March 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NoFunctionalChanges Trivial extremely simple issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants