Skip to content

Conversation

@panleone
Copy link

@panleone panleone commented May 14, 2023

This is a trivial but quite annoying bug fix. Basically once a transaction is actually sent from the GUI (so a few seconds after the user presses on "SEND" in the confirmation screen) the focus goes back to the "Recipient address" field regardless the screen the user is currently on.

Now once the "SEND" button is pressed the focus on "Recipient address" is already (and istantly) gained by the function showEvent in send.cpp, so to fix this issue I simply removed the call to setFocusOnLastEntry that happens when the transaction is actually sent (which is therefore completely useless).

This PR also solves #2597 and #1566

@panleone panleone self-assigned this May 14, 2023
@panleone panleone added this to the 6.0.0 milestone May 14, 2023
Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK f7ed184

I have found the issue that I was having on Mac, which would be semi-out of scope and trivial to do here.
We can discuss options in Discord from what I found.
Good fix!

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f7ed184

@Fuzzbawls Fuzzbawls merged commit 6c26a0e into PIVX-Project:master Aug 10, 2023
@Fuzzbawls Fuzzbawls modified the milestones: 6.0.0, 5.6.0 Feb 6, 2024
@panleone panleone deleted the send_focus branch March 23, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants