[Wallet] Locked sapling notes #2861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panleone
force-pushed
the
locked_notes
branch
4 times, most recently
from
50826ca to
141fb78
Compare
Author
|
rebased on master to resolve conflict |
Liquid369
previously approved these changes
May 17, 2023
Member
Liquid369
left a comment
Liquid369
left a comment
There was a problem hiding this comment.
tACK 141fb7892cad3760fa10cb5d45306f075052b0e3
Working pretty well, RPCs work nicely, and a nice quality of life improvement for shield users.
Author
|
had to rebase again due to new conflicts |
Fuzzbawls
added
the
Needs Release Notes
Fuzzbawls
approved these changes
May 28, 2023
Fuzzbawls
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the possibility to lock a sapling note, so the system will not try to spend it once a shield transaction is made. As for normal utxo locks are not saved on disk.
In particular I have updated two RPCs:
I have also updated the coin control interface so users will be able to lock a note from the GUI.