[GA] Overhaul GA caches #2857
Merged
[GA] Overhaul GA caches #2857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do away with timestamped chache key naming. This simplifies our cache storage situation considerably, especially given that our caches are automatically validated/refreshed as-needed by our internal build systems.
Simplify native builds by skipping the `distdir` step
These two jobs will serve as early detectors of issues in the most recent versions of each OS.
panleone
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-work the GA cache naming to be more straight forward and efficient overall. The previously attached timestamping was actually working against us, and leading to much wasted cache usage.
At the same time, this adds 4 additional jobs to test
ubuntu-latestandmacos-latestrunners for both cmake and native autotools, which can help provide early detection of build issues on the newest runner OSes.A new workflow is also added that will function as a "cache maintenance" workflow to delete PR branch caches when a PR is closed/merged. This is primarily a step to prevent us from exceeding the cache storage size limit and having more useful caches evicted needlessly.
Finally, the last commit is a macOS-latest only workaround to address a bug on Apple's end which was introduced in Xcode 14.x when using a clang compiler version that doesn't match Xcode's own compiler version (which we do because the default bundled clang compilers have been shown to not work with our CMake build system).