[Build] Minor fixups and simplifications for macdeploy #2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused since bitcoin#20422, see: bitcoin#20422 (comment)
Fuzzbawls
added
Build System
macOS
panleone
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified backport of bitcoin#22199.
Github Action's latest macOS 11 runner image has introduced a Qt plugin dylib issue that results in build failures for non-depends based builds (ref: https://github.com/PIVX-Project/PIVX/actions/runs/4610757401/jobs/8206287998). The particular dylib (
libwebp.dylib) is one that PIVX doesn't use, but themacdeployscript was originally written in a way that newer plugins that weren't explicitly excluded were linked, even if not necessarily needed.This PR changes the logic/process to instead only link explicitly defined needed plugins that PIVX Core directly uses. Depends based builds are unaffected by this change, as depends builds Qt as static libraries, which don't use Qt plugins.