[GUI] Proposal Generate Address #2828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
requested changes
Apr 1, 2023
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
first-pass look: Can squash the second commit into the first one.
Generally speaking; if a PR introduces new/changed code in one commit, then again changes that same code in a subsequent commit in the same PR, can usually just squash and avoid an otherwise redundant "fix" commit.
Liquid369
force-pushed
the
2023_gen_prop_addr
branch
from
7d53cb7 to
54c9664
Compare
Member
Author
|
Squashed the commits and fixed the nit |
Liquid369
force-pushed
the
2023_gen_prop_addr
branch
from
904f33b to
e4634a5
Compare
Fuzzbawls
previously approved these changes
Apr 4, 2023
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK de49eaf4c8f5c379c91427b0d93808fc4480cecb
panleone
reviewed
Apr 4, 2023
panleone
left a comment
panleone
left a comment
There was a problem hiding this comment.
good feature, but the button is too small
Liquid369
force-pushed
the
2023_gen_prop_addr
branch
from
e8525fb to
6a9f7df
Compare
Member
Author
Updated with larger button size to accommodate the text
Does it look better to you? May still need some adjustment. |
Liquid369
force-pushed
the
2023_gen_prop_addr
branch
from
039b0e7 to
fdbffe9
Compare
Fuzzbawls
approved these changes
Apr 26, 2023
panleone
approved these changes
Apr 26, 2023
Fuzzbawls
added
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new button to page 2 of the proposal creation process and uses the proposal name from the first page to assign a label to the newly generated address.
This streamlines proposal creation process for users not wanting to re-use addresses and be able to start the process without realizing they may not have copied an address, after having say copied the short URL if they created one and can just continue forward.
As well as tagging the newly created address with the Proposal Name so its easy to find in the Receive tab.