add include_delegated to vRPCConvertParams #2774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
uTACK 2334061 |
DeanSparrow
approved these changes
Oct 21, 2022
DeanSparrow
left a comment
DeanSparrow
left a comment
There was a problem hiding this comment.
ACK 2334061
Compiled and tested on testnet
Author
@Liquid369 could you please update your review with the Approve option, so this PR can be merged? |
Liquid369
approved these changes
Nov 3, 2022
Member
Done sorry for that |
Liquid369
approved these changes
Nov 4, 2022
Fuzzbawls
approved these changes
Nov 8, 2022
Fuzzbawls
added
the
Needs Backport
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Nov 22, 2022
Github-Pull: PIVX-Project#2774 Rebased-From: 2334061
Merged
Fuzzbawls
removed
the
Needs Backport
Fuzzbawls
added a commit
that referenced
this pull request
Dec 12, 2022
c0f6055 [Consensus] Bump v5.5 activation height for mainnet (Fuzzbawls) 200b908 [Consensus] Set v5.5 activation height for mainnet (Fuzzbawls) dc31cef Add functional test for scantxoutset (PeterL73) b452fb6 Remove commented out code (PeterL73) 3fc2e6b Backport scantxoutset and descriptors from BitCoin Core v0.17.2 (PeterL73) 8f5f52d Remove semicolon and add "verbose" back to vRPCConvertParams. (tecnovert) ba310d1 Test for hex strings and remove stray newline from rpc_named_arguments. (tecnovert) 2b244ba Fix missing help text and add backwards compatibility. (tecnovert) cce6951 rpc: Backport getblock verbosity (tecnovert) fd719a2 add include_delegated to vRPCConvertParams (PeterL73) d285af0 use block height from caller (PeterL73) Pull request description: Backports the following PRs to the `5.5` branch: #2772 #2774 #2779 #2780 #2781 #2784 Top commit has no ACKs. Tree-SHA512: b0858e8ce7a39a1a3399fb2cf3eb4c4e77ecd526d9c8ca38fab0dc1ca6d108c962a581c8e481d8ac584a35b8a88f58d9d887166a35aec8fdfb66e8d57232dfa8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed #2773
Spending with
sendmanyandinclude_delegatedparameter, results inJSON value is not a boolean as expectederrorinclude_delegatedis missing from vRPCConvertParamsWhat was done?
include_delegatedwas added to vRPCConvertParamsHow Has This Been Tested?
The transactions got added
Checklist: